[Affected versions]:

• 70.0a1 (2019-08-11)
• 69.0b12
• 68.0.1

[Affected platforms]:

• Windows 10
• Ubuntu 18.04
• macOS 10.13

[Steps to reproduce]:

1. Open Library (CTRL+Shift+B)
2. Go to any subsection from All Bookmarks section
3. Right-click - New Separator

[Expected result]:

• The separator is not disrupted

[Actual result]:

• The separator is disrupted

[Regression range]:

• Last good revision: 88803cf0dec1cffe6990cc48705d18591aaa9e2b
• First bad revision: 973b58266e4437e2cb14cd47d4cf8f052f4a1fa4
• Pushlog:
  https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=88803cf0dec1cffe6990cc48705d18591aaa9e2b&tochange=973b58266e4437e2cb14cd47d4cf8f052f4a1fa4

[Additional Notes]:

• Issue is more visible on hover.

ntim, this appears to be your regression. Could you look into this?

It turns out this wasn't dead code: https://hg.mozilla.org/integration/mozilla-inbound/rev/973b58266e4437e2cb14cd47d4cf8f052f4a1fa4#l19.14

This was removed in https://hg.mozilla.org/integration/mozilla-inbound/rev/973b58266e4437e2cb14cd47d4cf8f052f4a1fa4#l19.14 because it was thought to be dead code.

https://hg.mozilla.org/mozilla-central/rev/f815b5977a4f

Please nominate this for Beta & ESR68 approval when you get a chance.

Comment on attachment 9085155 [details]
Bug 1573161 - Restore padding: 0; on ::-moz-tree-twisty(title, separator) in tree-icons.css. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Visual bug in bookmarks library separators
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0 (it would also be nice to test on all 3 platforms)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Restores some small CSS that shouldn't have been removed.
• String changes made/needed: No

This issue is verified fixed with Fx 70.0a1 (2019-08-15) on Windows 10, Ubuntu 18.04 and macOS 10.13.

Comment on attachment 9085155 [details]
Bug 1573161 - Restore padding: 0; on ::-moz-tree-twisty(title, separator) in tree-icons.css. r=dao

Simple CSS fix. Approved for 69.0b15 and 68.1esr.

https://hg.mozilla.org/releases/mozilla-esr68/rev/646e8fb23115

https://hg.mozilla.org/releases/mozilla-beta/rev/f27beeba6968

This issue is also verified fixed with Fx 69.0b15 on Windows 10, Ubuntu 18.04 and macOS 10.13.

The issue is no longer reproducible with 68.1.0esr (20190823201228) on Windows 10, Ubuntu 18.04 and macOS 10.13.