Closed Bug 1571701 Opened 5 years ago Closed 4 years ago

Tooltip text color for page URL in the Site Identity not readable when dragged over tabs bar

Categories

(Firefox :: Site Identity, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 76
Tracking Status
firefox-esr68 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- verified

People

(Reporter: cfogel, Assigned: skanthavar, Mentored)

References

(Regression)

Details

(Keywords: polish, regression)

Attachments

(2 files, 1 obsolete file)

Attached image dragTip.gif

Affected versions

  • 70.0a1 (2019-08-05), 69.0b11, 68.0.1

Affected platforms

  • Windows 10 (light/dark theme), Ubuntu 18.04, macOS 10.14;

Steps to reproduce

  1. Launch Firefox, access any webpage;
  2. Grab the link - (i) button - and drag to open another tab;

Expected result

  • Text is visible;

Actual result

  • Text color is black (being dragged over the tabs-bar is not readable);

Regression range

  • introduced with bug 1208858;
  • pre-text: build_date: 2019-04-09 11:12:23.600000 changeset: 98b223de054374a3fba8669750eed1a8b3247baa
  • post text: build_date: 2019-04-09 17:45:32.875000 changeset: 8e92ef0be5a1ad8c15beb01328780078760ecf19

Additional notes

  • attached recording with the issue.

The text colour for dark theme when dragging from the URL bar should be the same colour as the text in open tabs. Thanks

Component: Site Identity and Permission Panels → Theme
Keywords: polish
Priority: -- → P3
Has Regression Range: --- → yes

The drag feedback isn't styled by the theme.

Component: Theme → Site Identity and Permission Panels
Priority: P3 → --
Priority: -- → P3

Could I please work on this?

Johann suggested that a cleaner solution for this would be to provide the text with a white background in dark mode like chrome does. To get started on this you can use https://searchfox.org/ and also the Browser Toolbox to inspect this element as we explain in our hackmd document. Please don't hesitate to ping us on Matrix @osfcep if you're stuck :)

Assignee: nobody → skanthavar
Status: NEW → ASSIGNED
Mentor: prathikshaprasadsuman, jhofmann
Attachment #9132058 - Attachment is obsolete: true
Attachment #9132186 - Attachment description: Bug 1571701 - Fix tooltip text color for page URL in the Site Identity when dragged over tabs bar. r=prathiksha → Bug 1571701 - Fix tooltip text color for page URL in the Site Identity when dragged over tabs bar. r=johannh
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a184b9023e3
Fix tooltip text color for page URL in the Site Identity when dragged over tabs bar. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

Verified with 76.0a1 ( 2020.03.230).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: