Closed Bug 1567432 Opened 5 years ago Closed 4 years ago

[Win] High Contrast mode missing icons, hover/active states

Categories

(Toolkit :: Add-ons Manager, defect, P3)

Desktop
Windows
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox68 --- affected
firefox69 --- affected
firefox70 --- affected
firefox73 --- fixed
firefox74 --- fixed

People

(Reporter: atrif, Unassigned)

Details

Attachments

(2 files)

Attached image 3_dot_missing.png

Affected versions

  • Firefox 68.0.1 (20190717172542)
  • Firefox 69.0b6 (20190718172058)
  • Firefox 70.0a1 (20190718215316)

Affected platforms

  • Windows 10x64
  • Windows 7x64

Preconditions

  • Enable High Contrast (Settings -> Ease of Access -> High Contrast -> Turn on high contrast).

Steps to reproduce

  1. Launch Firefox and go to about:addons page.
  2. Select the Themes category.
  3. Observe the ellipsis (3-dot) icon from the Default, Dark or Light themes.

Expected result

  • There are no visual glitches when using high contrast.

Actual result

  • The ellipsis (3-dot) icon from the themes is not present and it’s replaced with an empty square.

Regression Range

  • Reproducible with Firefox 69.0a1 (20190615214733). I will search for one ASAP.

Additional Notes

  • The issue is reproducible on every installed addon that has the 3-dot icon.
  • Attached a screenshot with the issue.
Has Regression Range: --- → no
Has STR: --- → yes

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Hello!
I tried searching for a regression range but with no luck, because the issue is reproducing way back to the implementation of the ellipsis (3-dot) icon (20190317213820). I will remove the flags accordingly. If there is anything I cand help with please let me know. Thank you!

Has Regression Range: no → ---

Looks like to fix that icon we'll need to switch it from a background image to a regular image or <input type="image">.

In addition there is also no active state in the sidebar, no hover states in the more options menu, no visual component to the separators in the menu (should use border-top instead of being 1px w/ background), and the borders for the tabs on the details page are a little weird.

Summary: [Win] Using High Contrast makes ellipsis (3-dot) icon disappear in about:addons page → [Win] High Contrast mode missing icons, hover/active states
Priority: -- → P3

hello! I think this is fixed as of readability backplate landing. can you confirm if the issue persists in nightly? (with permitBackplate enabled in about:config)

Flags: needinfo?(alexandru.trif)

Hello! It seems that the issue is fixed on the latest Nightly 74.0a1 (20200113204142) and Firefox 73.0b4 (20200112220634). On high contrast mode, the 3-dot ellipsis is shown accordingly: screenshot.
Closing this as works for me and modifying the flags. Thank you!

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(alexandru.trif)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: