Rename text-decoration-width to text-decoration-thickness, to match compat & current spec
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: dholbert, Assigned: cmarlow)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
Apparently the CSSWG has gone back and forth about the "text-decoration-width" vs. "text-decoration-thickness" naming, but as Jen notes in bug 1555865 comment 3, the "-thickness" name seems to have won for the moment.
The Editor's Draft did still use "-width" up until recently, but fantasai changed it to "-thickness" here, 22 days ago, in response to a December 2018 csswg resolution:
https://github.com/w3c/csswg-drafts/commit/ffbfa0685c9a1714411b19c0b4abab6a01d5bd48
She did also add this caveat:
ISSUE 1: While text-decoration-thickness seems to be more intuitive than text-decoration-width for English-speakers, other line-thicknesses in CSS (e.g. border-width and column-rule-width) are called “widths”.
...but for the moment "thickness" seems to be the latest word from the CSSWG/spec, and it's also what Safari is currently shipping, so we should probably switch for both compat & spec-compliance reasons.
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Reporter | |
Comment 2•5 years ago
|
||
Would you mind sending a followup message to dev-platform (as a reply to your original post at https://groups.google.com/d/msg/mozilla.dev.platform/VWcV5QUzJF0/O9hET80TAgAJ ), to note that we're changing the property name and the pref name? (in response to the spec change at https://github.com/w3c/csswg-drafts/commit/ffbfa0685c9a1714411b19c0b4abab6a01d5bd48 )
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35043a8b9d81 renamed text-decoration-width to text-decoration-thickness r=dholbert
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17941 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 8•5 years ago
|
||
sebo, I noticed you added some text about this feature at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#text-decoration-thickness -- would you mind updating it, to account for this rename?
The situation is basically as follows:
(1) Firefox 69 supports this feature (preffed off) under the name text-decoration-width, behind the pref layout.css.text-decoration-width.enabled
(2) Firefox 70 supports* this feature (preffed off, for now) under the name text-decoration-thickness, behind the pref layout.css.text-decoration-thickness.enabled
(The text that's currently on MDN captures (1) but doesn't yet capture (2))
Thanks!
*as of tomorrow's Nightly (via the m-c commit in comment 7)
Upstream PR merged
|
||
Comment 10•5 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #8)
sebo, I noticed you added some text about this feature at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#text-decoration-thickness -- would you mind updating it, to account for this rename?
Thank you for the hint, Daniel! I've added the info about the name change in Firefox 70.
Sebastian
|
|
||
Comment 11•5 years ago
|
||
Ah, and let's add the 'dev-doc-needed' flag so the MDN team knows this new property still needs to get documented.
Sebastian
|
||
Comment 12•5 years ago
|
||
To make life a bit more complication (sorry) I just proposed perhaps changing the name to text-decoration-weight. Hopefully this will be discussed and decided quickly.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 13•5 years ago
|
||
Documented; see https://bugzilla.mozilla.org/show_bug.cgi?id=1573631#c14
|
|
Reporter | |
Updated•5 years ago
|
Description
•