Closed Bug 1566335 Opened 5 years ago Closed 5 years ago

Import Saved logins close button (x) lacks padding

Categories

(Toolkit :: Password Manager, defect)

defect
Not set
minor

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix

People

(Reporter: cfogel, Unassigned)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image savedLogins_X.png

Affected versions

  • 68.0, 69.0b4 , 70.0a1 (2019-07-15);

Affected platforms

  • Windows 10, macOS 10.13, Ubuntu 18.04;

Steps to reproduce

  1. Launch Firefox;
  2. Click on the Hamburger menu button;
  3. Click on the Logins and Passwords button;
  4. Type anything inside the Search field to fill the section;

Actual result

  • (X) button left-right spacing is small compared to the search icon;

Expected result

  • add extra left-right padding to the button (~2px would suffice);

Regression range

  • First bad
    build_date: 2019-05-17 17:46:47.191000
  • Last good build_date: 2019-05-17 11:04:47.339000 changeset: 839cdad764d741ab4438b6feabeec749a22b34d5 changeset: c94c54aff4669f52cebc76ddad34a76f4fafd03b
  • Pushlog: URL

Additional notes

  • attached screenshot with the issue;
  • the previous implementation had the button with different styling and it had the extra space.
Has Regression Range: --- → yes
Has STR: --- → yes

In about:preferences#privacy - Saved Logins area the same button could use some spacing - on the left side.
Please advise if another bug needs to be filed for it.

This is getting replaced by about:logins.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: