Open Bug 1562854 Opened 5 years ago Updated 2 years ago

Properly center text on Blacklist button from about:url-classifier

Categories

(Toolkit :: Safe Browsing, defect, P3)

defect

Tracking

()

Tracking Status
firefox-esr60 --- unaffected
firefox67 --- affected
firefox68 --- affected
firefox69 --- affected

People

(Reporter: cfogel, Unassigned)

Details

Attachments

(1 file)

Note

Affected versions

  • Firefox 68.0, 68.0b13,

Affected platforms

  • Windows 10, macOS 10.14, Ubuntu 16.04;

Steps to reproduce

  1. Launch Firefox and access about:url-classifier
  2. Click on the Blacklist button from the list type section.

Expected result

  • Elements are properly centered within their containers;

Actual result

  • The text baseline is the same as for the dropdown button icon;

Regression range

  • not a regression;
  • initial issue appeared with adding the dropdown (bug 1513298);
  • bug 1539089 addressed the issue, but the fix is incomplete;

Additional notes

  • it would look better if both are centered;
  • as per my comments from that bug, with the current implementation the text would need to be moved lower by ~2px in the button
  • while at it, even the dropdown menu would benefit from some extra padding;

Attaching screenshot for better visibility

Priority: -- → P3
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: