[Affected versions]:

• 69.0a1 (2019-06-24) (64-bit)

[Affected platforms]:

• macOS 10.14
• macOS 10.13

[Unaffected platforms]:

• Windows 10x64
• Ubuntu 18.4x64

[Steps to reproduce]:

1. Launch Firefox
2. Go to Preferences/Permissions
3. Go to Autoplay and open Settings
4. Click on the Autoplay global settings
5. Observe the drop down alignment for autoplay options

[Expected result]:

• Global autoplay options drop down is not properly alligned

[Actual result]:

• Global autoplay drop down should be properly aligned, see the correct screenshot from Windows 10

[Regression range]:
Not regression, new feature

Dale, can you check what's going on here? Thanks!

Hey Neil, Gijs informed me you had worked around this area

The menupopup here is contained within a <browser> so doesnt have enough horizontal space to show centered on the selected item the left margin however still shows. If I set position="after_end" on the menupopup then it shows as it does in windows, but I cant do that from just <menuitem> and seems like this should be handled automatically

Any suggestions on what I should do to fix this?

Cheers
Dale

The horizontal alignment in the image looks correct to me. On Mac, the popup should appear offset left of the button area by 13 pixels.

Are you talking about the vertical alignment? The vertical alignment isn't correct as it appears to be cut off by the subwindow frame. You could fix that by adding incontentshell="true" to the iframe the subwindow frame is using.

(In reply to Neil Deakin from comment #5)

The horizontal alignment in the image looks correct to me. On Mac, the popup should appear offset left of the button area by 13 pixels.

Really? It looks off to me... It looks OK when we manage to overlay the popup on top of the menulist, with the selected item shown on top of the menulist element, but not when we show the popup below/above the anchoring menulist. Is this what Safari and other native apps do everywhere?

Are you talking about the vertical alignment? The vertical alignment isn't correct as it appears to be cut off by the subwindow frame. You could fix that by adding incontentshell="true" to the iframe the subwindow frame is using.

Looks like we'd want to add this to the <menupopup>, right?

Are you talking about the vertical alignment? The vertical alignment isn't correct as it appears to be cut off by the subwindow frame. You could fix that by adding incontentshell="true" to the iframe the subwindow frame is using.

Looks like we'd want to add this to the <menupopup>, right?

Thanks setting this worked great

https://hg.mozilla.org/mozilla-central/rev/0d8f537f9a7c

(In reply to :Gijs (he/him) from comment #6)

Really? It looks off to me... It looks OK when we manage to overlay the popup on top of the menulist, with the selected item shown on top of the menulist element, but not when we show the popup below/above the anchoring menulist. Is this what Safari and other native apps do everywhere?

This is consistent with native dropdowns.

Verified as fixed with macOS 10.12.6 and macOS 10.10 on 69.0b6.

Please nominate this for ESR68 approval when you get a chance.

Comment on attachment 9075809 [details]
Bug 1561266 - Let popup display out of the permissions popup.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Visible layout fix
• User impact if declined: incorrect layout
• Fix Landed on Version: 69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor layout change, verified
• String or UUID changes made by this patch:

Comment on attachment 9075809 [details]
Bug 1561266 - Let popup display out of the permissions popup.

Fixes a minor UI regression. Approved for 68.1esr.

This change patches code which got added in 69 in bug 1543812. Does anything need to be done here for esr68?

Nope I should have checked before the uplift requet, this UI isnt on 68 so nothing to do here, sorry

Can you remove the approval-mozilla-esr68+, please? (Not needed, see comment 17.)