Open Bug 1561200 Opened 5 years ago Updated 2 years ago

[BITS] BITS falling to nsIIncrementalDownload when using a proxy at os level

Categories

(Toolkit :: Application Update, defect, P3)

68 Branch
Desktop
Windows
defect

Tracking

()

Tracking Status
firefox68 --- affected
firefox69 --- affected

People

(Reporter: atrif, Unassigned)

References

Details

Attachments

(2 files)

Attached file BITS_update_.txt

Affected versions

  • Firefox 68.0b13 (20190617172838)
  • Firefox 69.0a1 (20190624213657)

Affected platforms

  • Windows 10 x64
  • Windows 7x64

Preconditions

  • Set app.update.BITS.enabled and app.update.log to true.
  • Go to Internet Options -> Connections -> Lan Settings -> Use a proxy server for your LAN and set a valid ip address and a port for proxy server.

Steps to reproduce

  1. Launch Firefox and log in with valid credentials for the proxy when prompted.
  2. Open menu -> Help -> About Firefox.
  3. Open browser console.

Expected result

  • The update download is made using BITS.

Actual result

  • An error is presented and the update download is made using nsIIncrementalDownload.

Regression Range

  • I will search for a regression range ASAP.

Additional Notes

  • Attached a log with browser console error.
  • Update was performed from Firefox 68.0b11 (20190617172838).
Has Regression Range: --- → no
Has STR: --- → yes

I'm afraid I cannot currently reproduce the issue. I set my proxy to 208.123.76.34:8080 using the method that you described, and I observed Firefox updating normally using BITS. Perhaps this is because the proxy that I am using does not require credentials? You mentioned entering valid credentials.

I'm afraid that I haven't the fainest clue how proxies that require credentials work. I'm not sure how to create one or find one that I can use to test this. Does a login window just pop up when you open Firefox? Is this a Firefox modal? A Windows modal? Does it set the credentials just for Firefox, or for the entire user's session? Do they expire?

Sorry that I am not more knowledgeable on this topic.

Flags: needinfo?(alexandru.trif)
Attached image BITS_proxy.gif

Hello Kirk,

I made a screen recording regarding all process that leads to the issue. When starting Firefox a login window will appear that asks for valid proxy credentials (entering wrong ones only makes the window display again). From what I saw the window is Firefox modal because it’s almost similar with “Master Password” window and “Default Browser” one and because it’s different from the other ones. The credentials are set only for Firefox and almost every other app requires them and that’s why I’m thinking that maybe BITS cannot work because of the credentials but I don’t have an idea how to test this… I am sorry but I don’t know if they have an expiration time but I didn’t saw that while using them. The proxy we use are from https://proxy-seller.com/american-proxy . Using proxy that does not require authentication is working fine. We used squid to configure the proxy settings and no auth was required and Firefox was updated using BITS.

I've made some researching about BITS using a proxy server that requires credentials and I found this: "If you expect the proxy or server to require user credentials, you must provide the credentials to BITS". Unfortunately, I was not able to set the credentials to BITS using this tutorial. Can you help me here? Thank you!

Also from what I saw the issue is reproducible when updating from Firefox 68.0b3 (20190318154932).

Flags: needinfo?(alexandru.trif)
Flags: needinfo?(ksteuber)
Priority: -- → P3
Flags: needinfo?(ksteuber)

We're checking to see how many users are impacted by this, but at this point we believe it's a small subset of proxy users. Fallback works so nothing breaks here. Marking this a P3 to be worked on this fall when we get some free time. Once we get some telemetry on this if it looks like a larger issue we'll reassess.

This sounds mostly like an enterprise config so perhaps worth having as a known issue for ESR68 so admins of proxy users with auth can disable BITS if needed.

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: