“About:welcome” cards overlapping issue with the browser resized to minimum width
Categories
(Firefox :: Messaging System, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | unaffected |
firefox67.0.1 | --- | wontfix |
firefox68 | --- | wontfix |
firefox69 | --- | verified |
firefox70 | --- | verified |
People
(Reporter: asoncutean, Assigned: emcminn)
References
(Blocks 2 open bugs)
Details
(Keywords: github-merged)
Attachments
(3 files)
[Affected versions]:
- 67.0.2
- 68.0b7
- 69.0a1 (2019-05-06)
[Affected platforms]:
- Windows 10 x64
- macOS 10.14
- Ubuntu 18.04 x64
[Steps to reproduce]:
- Open Firefox with a clean profile
- Dismiss the “Welcome to Firefox” modal
- Resize the window to its minimum width
- Observe the last “Welcome to Firefox” card
[Expected result]:
- Cards are entirely visible.
[Actual result]:
- The bottom of the last card is hidden behind about:newtab page
[Regression range]:
- This issue is not a regression, introduced as part of Trailhead Desktop First Run feature implementation
[Additional Notes]:
- Make sure trailhead.firstrun.branches is set to join-privacy in about:config before opening about:welcome page for Nightly and Beta.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Comment 2•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f70de7f07a6
This landed https://github.com/mozilla/activity-stream/commit/5951c4947bea1a4eeed45f974ff9a51e33641c9f with no bug number.
Comment 3•5 years ago
|
||
I have verified that the issue is no longer reproducible on the latest Nightly 70.0a1 (Build ID 20190713215744) on Windows 10, macOS 10.14, and Arch Linux 14.4.3.
Comment 4•5 years ago
|
||
Is this something we should consider uplifting to Beta for Fx69?
Assignee | ||
Comment 5•5 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
Is this something we should consider uplifting to Beta for Fx69?
I would say yes; I think @Mardak was going to handle the uplifts for this bug and a couple others.
Comment 6•5 years ago
|
||
Comment 7•5 years ago
•
|
||
After reviewing the phabricator patch, you'll need to request beta uplift (set approval-mozilla-beta to "?" in the drop down on the left and fill out the form on the right) from the attachment details page: https://bugzilla.mozilla.org/attachment.cgi?id=9080188&action=edit
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9080188 [details]
Bug 1557304 - “About:welcome” cards overlapping issue with the browser resized to minimum width
Beta/Release Uplift Approval Request
- User impact if declined: Users won’t be able to read first run content on smaller screen sizes
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce: See QA steps in https://bugzilla.mozilla.org/show_bug.cgi?id=1557304
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Little to no risk; just a small CSS change that affects the smallest media size.
- String changes made/needed:
Comment 9•5 years ago
|
||
Comment on attachment 9080188 [details]
Bug 1557304 - “About:welcome” cards overlapping issue with the browser resized to minimum width
Fixes overlapping about:welcome cards on some smaller screen sizes. Approved for 69.0b8.
Comment 10•5 years ago
|
||
bugherder uplift |
Comment 11•5 years ago
|
||
uplift |
Backed out as https://hg.mozilla.org/releases/mozilla-beta/rev/3213cec0957dc8a0d8bce65cddeaf031b32ea881 and relanded with correct commit information: https://hg.mozilla.org/releases/mozilla-beta/rev/4c7568ba85fbde80403a91b7ad3911bde07994c6
Reporter | ||
Comment 12•5 years ago
|
||
I can confirm also, this issue is no longer reproducible on the Beta 69.0b8 on Windows 10, macOS 10.13 and Ubuntu 18.04.
Description
•