Closed Bug 1557121 Opened 6 years ago Closed 6 years ago

Implement Blob.text()/Blob.arrayBuffer()/Blob.stream()

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla69

Tracking Flags:

Tracking

Status

relnote-firefox

---

firefox69

---

fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Keywords: dev-doc-complete)

Attachments

(7 files)

Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 1 - Rename FetchStream to BodyStream, r?smaug 6 years ago Andrea Marchesini [:baku] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 2 - FetchBodyConsumer doesn't need to be a template class, r?smaug 6 years ago Andrea Marchesini [:baku] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 3 - Rename FetchBodyConsumer to BodyConsumer, r?smaug 6 years ago Andrea Marchesini [:baku] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 4 - blob.text()/blob.arrayBuffer(), r?smaug 6 years ago Andrea Marchesini [:baku] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 5 - blob.stream(), r?smaug 6 years ago Andrea Marchesini [:baku] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 6 - tests, r?smaug 6 years ago Andrea Marchesini [:baku] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 7 - WPT, r?smaug 6 years ago Andrea Marchesini [:baku] 47 bytes, text/x-phabricator-request		Details \| Review

Andrea Marchesini [:baku]

Assignee

Description

•

6 years ago

These 3 methods are new in the spec. Chrome is going to ship them (they already pass WPT tests). Would be nice to ship them too.

Andrea Marchesini [:baku]

Assignee

Comment 1

•

6 years ago

Attached file Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 1 - Rename FetchStream to BodyStream, r?smaug — Details

Andrea Marchesini [:baku]

Assignee

Comment 2

•

6 years ago

Attached file Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 2 - FetchBodyConsumer doesn't need to be a template class, r?smaug — Details

Depends on D33826

Andrea Marchesini [:baku]

Assignee

Comment 3

•

6 years ago

Attached file Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 3 - Rename FetchBodyConsumer to BodyConsumer, r?smaug — Details

Depends on D33827

Andrea Marchesini [:baku]

Assignee

Comment 4

•

6 years ago

Attached file Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 4 - blob.text()/blob.arrayBuffer(), r?smaug — Details

Depends on D33828

Andrea Marchesini [:baku]

Assignee

Comment 5

•

6 years ago

Attached file Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 5 - blob.stream(), r?smaug — Details

Depends on D33829

Andrea Marchesini [:baku]

Assignee

Comment 6

•

6 years ago

Attached file Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 6 - tests, r?smaug — Details

Depends on D33830

Andrea Marchesini [:baku]

Assignee

Comment 7

•

6 years ago

Attached file Bug 1557121 - Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 7 - WPT, r?smaug — Details

BugBot [:suhaib / :marco/ :calixte]

Comment 8

•

6 years ago

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Type: defect → enhancement

Pulsebot

Comment 10

•

6 years ago

Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b83fb79138d7 Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 1 - Rename FetchStream to BodyStream, r=smaug https://hg.mozilla.org/integration/autoland/rev/c96028ee8aa4 Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 2 - FetchBodyConsumer doesn't need to be a template class, r=smaug https://hg.mozilla.org/integration/autoland/rev/0a49beaf7f21 Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 3 - Rename FetchBodyConsumer to BodyConsumer, r=smaug https://hg.mozilla.org/integration/autoland/rev/28eb82bc47f7 Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 4 - blob.text()/blob.arrayBuffer(), r=smaug https://hg.mozilla.org/integration/autoland/rev/318564bd3614 Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 5 - blob.stream(), r=smaug https://hg.mozilla.org/integration/autoland/rev/b7387f0cad9f Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 6 - tests, r=smaug https://hg.mozilla.org/integration/autoland/rev/4f5df7ee7541 Implement Blob.text()/Blob.arrayBuffer()/Blob.stream() - part 7 - WPT, r=smaug

Eric Shepherd [:sheppy]

Updated

•

6 years ago

Keywords: dev-doc-needed

Andreea Pavel [:apavel]

Comment 11

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/b83fb79138d7
https://hg.mozilla.org/mozilla-central/rev/c96028ee8aa4
https://hg.mozilla.org/mozilla-central/rev/0a49beaf7f21
https://hg.mozilla.org/mozilla-central/rev/28eb82bc47f7
https://hg.mozilla.org/mozilla-central/rev/318564bd3614
https://hg.mozilla.org/mozilla-central/rev/b7387f0cad9f
https://hg.mozilla.org/mozilla-central/rev/4f5df7ee7541

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox69: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla69

Hsin-Yi Tsai (she/her) [:hsinyi]

Comment 12

•

6 years ago

:baku,
Do you think this is notable in the release note? If so, care to nominate is? Thank you.

Flags: needinfo?(amarchesini)

Andrea Marchesini [:baku]

Assignee

Comment 13

•

6 years ago

Release Note Request (optional, but appreciated)
[Why is this notable]: It's an important change in the FileAPI and in how to read data from Blob objects.
[Affects Firefox for Android]: no
[Suggested wording]: Blob.text(), Blob.arrayBuffer(), Blob.stream() are 3 new methods to read data from a Blob object.
[Links (documentation, blog post, etc)]: https://w3c.github.io/FileAPI/#dom-blob-stream https://w3c.github.io/FileAPI/#dom-blob-text https://w3c.github.io/FileAPI/#dom-blob-arraybuffer

relnote-firefox: --- → ?

Flags: needinfo?(amarchesini)

Julien Cristau [:jcristau]

Comment 14

•

6 years ago

That change seems of interest to web developers not the general firefox userbase, so I guess more suitable for MDN than the main release notes?

Pascal Chevrel:pascalc

Comment 15

•

6 years ago

Andrea, can you clarify if you want this mentioned in both our developer's notes (MDN page) and our general notes on www.mozilla.org or only on our developer's notes? Thanks

Flags: needinfo?(amarchesini)

Andrea Marchesini [:baku]

Assignee

Comment 16

•

6 years ago

(In reply to Pascal Chevrel:pascalc from comment #15)

Andrea, can you clarify if you want this mentioned in both our developer's notes (MDN page) and our general notes on www.mozilla.org or only on our developer's notes? Thanks

This is for web developers only. Thank you.

Flags: needinfo?(amarchesini)

Pascal Chevrel:pascalc

Comment 17

•

6 years ago

Thanks, the dev-doc-needed keyword is enough then.

relnote-firefox: ? → -

Eric Shepherd [:sheppy]

Comment 18

•

6 years ago

Documentation has been updated:

Updated Blob.stream()
Updated Blob.text()
Updated Blob.arrayBuffer()
Cleaned up Blob.size
Cleaned up Blob.type
Cleaned up Blob; converted a sample to live
Cleaned up the Blob() constructor
Submitted PR 4816 to add new items to BCD

Keywords: dev-doc-needed → dev-doc-complete

Ryan VanderMeulen [:RyanVM]

Updated

•

5 years ago

Regressions: 1577311

You need to log in before you can comment on or make changes to this bug.