[css-fonts] font-size:xxx-large
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: mozilla-apprentice, Assigned: joel_1st, Mentored)
References
Details
(Keywords: dev-doc-complete, good-first-bug, Whiteboard: [lang=rust][wptsync upstream])
Attachments
(2 files)
A resolution was made for csswg-drafts/#3907.
[css-fonts] font-size:-webkit-xxx-large
- RESOLVED: Add `font-size: xxx-large` to Fonts level 4
Comment 1•5 years ago
|
||
This is basically replacing the #[css(skip)]
here by #[css(keyword = "xxx-large")]
, and then add tests.
Comment 2•5 years ago
|
||
Ya I'd like to pick this up 👍 2 questions though, what exactly should I be testing for and where should the tests be placed?
Comment 3•5 years ago
|
||
Not on my laptop atm, so leaving a ni? so I don't forget to reply. Please feel free to do it yoursel in the future, bugmail is easy to miss :)
Comment 4•5 years ago
|
||
(In reply to hgallagher from comment #2)
Ya I'd like to pick this up 👍 2 questions though, what exactly should I be testing for and where should the tests be placed?
Thanks! So, you should test at least that it parses, and that it computes to what you expect.
For the first, adding the value to property_database.js would be enough.
For the second, we should probably add some reftest to Web Platform Tests, something like:
<font size=7>Foo</font>
Should be equal to:
<span style="font-size: xxx-large">Foo</span>
.
You can probably crib from existing tests in testing/web-platform/tests/css/css-fonts
and add a new one. https://web-platform-tests.org/writing-tests/reftests.html has documentation on how to write reftests, but let me know if you have any question.
Thanks again!
Comment 5•5 years ago
|
||
I've asked in the chromium bug whether there are any other tests that they're working on. If not, some parsing tests would be nice on Web Platform Tests, but probably not required.
Updated•5 years ago
|
Comment 6•5 years ago
|
||
That's perfect thanks!, it's enough to get me started anyway
Comment 7•5 years ago
|
||
Tests that you can test that should test the property database include test_value_storage.html
and co (see all the tests that include that script in layout/style/test
).
Comment 8•5 years ago
|
||
Just a bit of an update. . .I haven't done anything with this yet because I was given a coding project to do as part of a job application last week so that took up all my time and I've just been given another today for another job application so it could be next week before I actually get round to this.
Comment 9•5 years ago
|
||
Sure, that's fine, thank you so much!
Assignee | ||
Comment 10•5 years ago
|
||
If hgallagher isn't actively working on this, I'd like to be assigned to this :)
Comment 11•5 years ago
|
||
Ya you can take it, I haven't got a chance to do anything on this, 1 of the coding projects I did has led to a job offer in the Netherlands and most of my time now will be spent getting ready to move country so I won't have much spare time to work on this
Comment 12•5 years ago
|
||
Yes, please go ahead then!
Let me know if you have any questions.
Assignee | ||
Comment 13•5 years ago
|
||
Assignee | ||
Comment 14•5 years ago
|
||
Depends on D41240
Comment 15•5 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/e8362711bb32 Enable font-size:xxx-large. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18374 for changes under testing/web-platform/tests
Comment 17•5 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/e800df0783d1 Remove now-incorrect comment. r=comment-only
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Updated•5 years ago
|
Comment 19•5 years ago
|
||
I think this comment needed to be removed too:
https://searchfox.org/mozilla-central/rev/7a5022a31fff48c9ffe6524a5a0dfec9b2f4e465/servo/components/style/values/generics/font.rs#256
Comment 21•5 years ago
|
||
bugherder |
Comment 22•5 years ago
|
||
bugherder |
Comment 23•5 years ago
|
||
This has been documented; see https://github.com/mdn/sprints/issues/2107 for a description of the changes.
Let me know if you think anything else needs to be said.
Description
•