Closed Bug 1551577 Opened 5 years ago Closed 3 years ago

[Inactive CSS] Display a warning when scroll-padding-* properties are used on a non-scrollable element

Categories

(DevTools :: Inspector: Rules, enhancement, P3)

enhancement

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: miker, Assigned: sebo)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Only valid on non-scrollable elements:

[
  "scroll-snap-coordinate",
  "scroll-snap-destination",
  "scroll-snap-points-x",
  "scroll-snap-points-y",
  "scroll-snap-type",
  "scroll-snap-type-x",
  "scroll-snap-type-y",
]

[This property] doesn't have an effect because the element doesn't scroll. Try adding a property like overflow:scroll.

(In reply to Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] from comment #0)

Only valid on non-scrollable elements:

[
  "scroll-snap-coordinate",
  "scroll-snap-destination",
  "scroll-snap-points-x",
  "scroll-snap-points-y",
  "scroll-snap-type",
  "scroll-snap-type-x",
  "scroll-snap-type-y",
]

[This property] doesn't have an effect because the element doesn't scroll. Try adding a property like overflow:scroll.

Those properties other than scroll-snap-type will be dropped in bug 1218265 and bug 1218264.

That's said, I think scroll-snap-type is also valid on scrollable element. It can be applied on all elements.

You are right:

Applies to: all elements

So I guess we need to drop this one.

@hiro Thanks for letting us know!

Priority: P2 → P3

According to the latest version of the specification, only scroll-padding-* properties are restricted to scroll containers. Therefore I've changed the summary accordingly.

Sebastian

Summary: [Inactive CSS] Display a warning when scroll-snap-* properties are used on a non-scrollable element. → [Inactive CSS] Display a warning when scroll-padding-* properties are used on a non-scrollable element
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED

Nicolas, could you please do the review?

Sebastian

Flags: needinfo?(nchevobbe)

sure, sorry for the delay

Flags: needinfo?(nchevobbe)
Pushed by sebastianzartner@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/576f61f7bb0f
New inactive CSS rule to show warning when scroll-padding-* is used on non-scrollable elements. r=nchevobbe,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: