John Dobbins Reporter
	Description • 22 years ago

spinbuttons.css refers to icons that are no longer there.

In Classic,
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/mac/spinbuttons.css
and
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/win/spinbuttons.css
have referances like this
.up {
  list-style-image: url("chrome://global/skin/spinbtn-up.gif")
}
All icons were removed from the global directory in December. No new directory
was created to hold these icons.

In Modern,
http://lxr.mozilla.org/seamonkey/source/themes/modern/global/spinbuttons.css
refers to
.up {
  list-style-image: url("chrome://global/skin/spinbuttons/btn-up.gif");
}
There is no spinbuttons directory holding these icons.

	HJ
	Comment 1 • 22 years ago

Hakan, can you help us with the missing images? Thanks.

	Håkan Waara
	Comment 2 • 22 years ago

This did work, I know glazou used the spinbuttons widget in his XUL application;
someone broke it, and it sure wasn't me! :-)

CC'ing some random people, does anyone have any idea?

	Daniel Glazman (:glazou) (not active in Mozilla any more)
	Comment 3 • 22 years ago

Yes, I do use spinbuttons

	HJ
	Comment 4 • 22 years ago

Hakan or Daniel, can one of you guys please commit the missing images into the
tree, this way we can have a go with the buttons, I don't have a clue what they
do/can do yet.

	John Dobbins Reporter
	Comment 9 • 21 years ago

I Found Copies of the missing icons and added attached them to this bug.

	Daniel Glazman (:glazou) (not active in Mozilla any more)
	Comment 10 • 20 years ago

Taking bug

	neil@parkwaycc.co.uk
	Comment 11 • 20 years ago

This should so be done with CSS borders and backgrounds.

	Daniel Glazman (:glazou) (not active in Mozilla any more)
	Comment 12 • 20 years ago

(In reply to comment #11)
> This should so be done with CSS borders and backgrounds.

Right.

	neil@parkwaycc.co.uk
	Comment 13 • 20 years ago

*** Bug 276146 has been marked as a duplicate of this bug. ***

	Richard Klein
	Comment 14 • 20 years ago

I'm going ask for 1.1 blocking on a couple of spinbutton bugs.  We have been
trying to use them in our ForcastFox extension, but they won't theme correctly
since we have to supply our own images.

	zug_treno
	Comment 15 • 19 years ago

*** Bug 319088 has been marked as a duplicate of this bug. ***

	Neil Deakin Assignee
	Comment 16 • 18 years ago

Morphing this bug into one about making the <spinbuttons/> a real XUL element with  propery properties, methods and events, etc.

	neil@parkwaycc.co.uk
	Comment 19 • 18 years ago

I can't see any code that draws the spinbuttons on Windows 2000 or BeOS?

	Neil Deakin Assignee
	Comment 20 • 18 years ago

Added to Windows spinbuttons.css, but otherwise unchanged.

The only issue is that for xpfe, the spinbuttons appears too tall, but I can't figure out what the reason for that is. Different images, maybe?

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 21 • 18 years ago

Comment on attachment 225034 [details] [diff] [review]
native theme changes for spinbuttons

mostly a rubber-stamp...

	neil@parkwaycc.co.uk
	Comment 22 • 18 years ago

(In reply to comment #20)
>The only issue is that for xpfe, the spinbuttons appears too tall, but I can't
>figure out what the reason for that is. Different images, maybe?
You're using the 11x11 arrow images that Classic has. Strangely on my XP build the spinbuttons has a height of 22. Where did the borders go? I'm worried that the native theme code is overriding the border size even when it's not painting.

	neil@parkwaycc.co.uk
	Comment 23 • 18 years ago

I removed the -moz-appearance and it makes makes things look as expected.
I'd say that's bad :-(
Obviously if I was using Luna then I would expect it to override the size.

	neil@parkwaycc.co.uk
	Comment 24 • 18 years ago

The Modern styles are forcing the image to be 2px high which seems odd.

	Neil Deakin Assignee
	Comment 25 • 18 years ago

- fix up modern theme appearance
- for Classic themes, use background images for spinbuttons rather than list-style-images

	neil@parkwaycc.co.uk
	Comment 26 • 18 years ago

Comment on attachment 228842 [details] [diff] [review]
fix sizing issues

Well the good news is that the Modern theme looks quite nice. However, I'd say the Classic theme still has issues.
* I hunted around my RH7.3 linux box for some spinbuttons and found some that were 15x22 so I'm not sure where your dimensions came from.
* On Windows 2000, or Windows XP with Classic theme, the default height of the spinbuttons is zero. That's right, you don't even get any borders.
* On either platform, if you disable (or don't have) themeing (I do this because I don't like the GTK native themeing) then you do get to see the borders, but you have to set a height to see the arrows.
* Once I'd done that I noticed that an odd width looks better. In fact I'd say an odd width looks better in Modern too.

	Neil Deakin Assignee
	Comment 27 • 18 years ago

The spinbuttons look the right size on my FC4 system, comparing to various preference panels. Are you using gtk1?

	neil@parkwaycc.co.uk
	Comment 28 • 18 years ago

Comment on attachment 228991 [details] [diff] [review]
Fix issues described above by setting a minimum height

Still hacky but at least it works...

	neil@parkwaycc.co.uk
	Comment 29 • 18 years ago

So it looks as if the problem with the Classic theme was that when Classic themeimg was first written not all of the Classic* functions were implemented for spinbuttons, in they are given neither size, border nor background.