[Dedicated Profiles] The restart buttons don't work after the page refresh prompts to restart the browser
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox66 | --- | unaffected |
firefox67 | --- | verified |
firefox68 | --- | verified |
People
(Reporter: cbaica, Assigned: mossop)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
[Affected versions]:
- Fx68.0a1
[Affected platforms]:
- macOS 10.14
- Ubuntu 18.04
- Windows 10 x64
[Pre-requisites]:
Have at least 2 different installs of the latest nightly with DP feature.
[Steps to reproduce]:
- Launch the first build and go to the about:profiles page.
- Leave that build running with the about:profiles page loaded.
- Launch the second build.
- Go back to the first build about:profiles page and refresh it (click the refresh button or hit F5 on the keyboard).
- Click the 'Restart Normaly...' button or 'Restart with Addons disabled'.
[Expected result]:
- The buttons don't work.
[Actual result]:
- The buttons should restart Firefox.
[Regression range]:
- This is cause by bug 1529879 implementation.
[Additional notes]:
- The buttons work without any issues if no refresh is done on the page.
- I would say this will block the uplift to beta
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd06c4854aba about:profiles buttons should be initialised when the UI loads, not everytime the UI is refreshed. r=jaws
Comment 4•5 years ago
•
|
||
Backed out changeset fd06c4854aba (Bug 1545736) for bc failures at browser_policy_disable_safemode.js.
Backout: https://hg.mozilla.org/integration/autoland/rev/89bac5e8dbb68876891ca741c882fc0d716ea72d
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fd06c4854abacefd68771c2f7ae575ec8e0ec69d&selectedJob=241479743
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241471936&repo=autoland&lineNumber=5336
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6ffe4f5a3c47 about:profiles buttons should be initialised when the UI loads, not everytime the UI is refreshed. r=jaws
Comment 6•5 years ago
|
||
bugherder |
Reporter | ||
Comment 7•5 years ago
|
||
Tested using Fx68.0a1 buildID: 20190421212635 on macOS 10.14, Ubuntu 18.04 LTS and Windows 10 x64. The buttons function without any issues.
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9059487 [details]
Bug 1545736: about:profiles buttons should be initialised when the UI loads, not everytime the UI is refreshed. r=Gijs
Beta/Release Uplift Approval Request
- User impact if declined: Users won't be able to restart Firefox from about:profiles if the profiles database is outdated.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1529879
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple fix to the UI initialisation code.
- String changes made/needed: None
Updated•5 years ago
|
Comment 9•5 years ago
|
||
Comment on attachment 9059487 [details]
Bug 1545736: about:profiles buttons should be initialised when the UI loads, not everytime the UI is refreshed. r=Gijs
Verified by QA on nightly + automated tests, uplift approved for 67 beta 14, thanks.
Comment 10•5 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 11•5 years ago
|
||
The issue is verified fixed using Fx67.0b14 buildID: 20190423190209 (intermediary build) on Ubuntu 18.04, macOS 10.14 and Windows 10 x64. The buttons work correctly on the refreshed about:profiles page.
Updated•2 years ago
|
Description
•