Closed Bug 1543045 Opened 5 years ago Closed 5 years ago

[Track changes] - Panel elements do not expand horizontally until a section resize

Categories

(DevTools :: Inspector: Changes, defect, P3)

defect

Tracking

(firefox66 wontfix, firefox67 wontfix, firefox68 verified)

VERIFIED FIXED
Firefox 68
Tracking Status
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- verified

People

(Reporter: cfogel, Assigned: rcaliman)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image TC1maxwidthIssues.gif

Affected versions

  • 66.0.2, 67.0b9, 68.0a1 (2019-04-08)

Affected platforms

  • Windows 10, macOS 10.14, Ubuntu 16.04

Steps to reproduce

  1. Launch Firefox, enable the devTools inspector with the Rules section and Changes tab being displayed;
  2. For any property-rule update the value with a really long string
    (ex, 40 characters of the same letter);
  3. In the changes tab, drag the horizontal scroll bar to see the end of the changed strings;

Expected result

  • the Changes view is properly displayed;

Actual result

  • the changes highlight(green/red) indicators are not expanded all the way towards the end of the section;
  • the separator is not expanded either;

Regression range

  • not a regression;

Additional notes

  • attached recording with the issue;
  • issue is not limited to the dark theme(as seen in the gif).
Priority: -- → P3
Summary: [Track changes] - tab elements have a fixed width, not expanding past the current width until a section resize → [Track changes] - Panel elements do not expand horizontally until a section resize

Introduce overflow-wrap: break-word to CSS declarations in Rules view and Changes panel to prevent long strings from causing unwanted horizontal scroll

Assignee: nobody → rcaliman
Status: NEW → ASSIGNED

Testing this solution a bit, I think it causes more issues than it solves the problem.

break-word will wrap all values at any place, meaning that long declarations e.g. for font-family will break values in the middle of a word. Since extra long value names without any kind of delimiter are an edge case, I'd prefer to keep the current wrapping and find a different solution for the background (or P5 and life with it).

Sorry just realized that the solution is break-word and not break-all as discussed on Slack, so nevermind 😅

Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e987641febc
Break strings for long CSS property names and values. r=gl
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Fix verified with 68.0a1 (2019-04-15).
Updating flags for the still affected versions.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: