Affected versions

• 67.0b8
• 68.0a1(2019-04-04)

Affected platforms

• Windows 10x64
• Ubuntu 16.04
• macOS 10.14

Steps to reproduce

1. Launch FF.
2. Go to any website (e.g: Wikipedia.com)
3. Inspect any element from the page.
4. In the second pane, right click and select Add New Rule.
5. Click enter or defocus the selector field.

Expected result

• The newly added string is displayed inside the Changes pane.

Actual result

• The newly added string is not displayed inside the Changes pane.

Introduces tracking for newly created CSS rules in the PageStyleActor.

Adds a boolean flag, isNew, to the tracked rule in the Changes Redux store. Using this flag, render the new rule's selector in the React component as added (plus sign, green background). Ensure selector changes for thew new rule always overwrite the original selector (fix for Bug 1542288) instead of erroneously showing the original selector as removed.

Removes obsolete documentation for "changeType" from the tracked rule in the Changes Redux store. This was never used.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ced36db9f93dfe4f2b06195b9be84558e5983b62

The patch for this bug includes a fix for Bug 1542288. Once this bug lands, we can close the other too.

https://hg.mozilla.org/mozilla-central/rev/0d0d5b67b2cc

Tracking as a portential uplift for beta 15, Bogdan could somebody in your team verify this bug in nightly today? Thanks

Comment on attachment 9059528 [details]
Bug 1542213 - Track newly added CSS rules in the Changes panel. r=pbro

Beta/Release Uplift Approval Request

• User impact if declined: In the Changes panel, tracking selectors of newly added CSS rules may confuse users to believe the CSS rule had existed before. This makes developers' lives harder when trying to reconcile the changes in their editor when exporting/copying. This patch fixes the issue and clearly marks new CSS rules in the Changes panel.

Lifting this to beta gives users a more solid experience in the upcoming release of Track Changes M2 reaching Firefox Release soon.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch reuses existing infrastructure to track newly added CSS Rules. The changes made aren't expected to negatively impact existing tracking.
• String changes made/needed:

Has the fix been verified in Nightly?: Yes

Sorry, I didn't realize this wasn't yet verified in Nightly.

Hello ,

Confirming this issue as verified fixed in 68.0a1 (2019-04-24)(20190424215525) on Windows 10x64, macOS 10.14 and Ubuntu 16.04x64.

Comment on attachment 9059528 [details]
Bug 1542213 - Track newly added CSS rules in the Changes panel. r=pbro

P1, fix covered by tests and verified on Nightly by QA, uplift approved for 67 beta 15, thanks.

https://hg.mozilla.org/releases/mozilla-beta/rev/d461f7c018d3

Thank you all for the uplift support!

Hello,

Confirming this issue as verified fixed on 67.0b15(20190429125729)on Windows 10x64, macOS 10.14 and Ubuntu 16.04