Entering “Manage data” in about:preferences#privacy with small browser window truncates the window
Categories
(Firefox :: Settings UI, defect, P3)
Tracking
()
People
(Reporter: atrif, Assigned: Gijs)
References
Details
Attachments
(2 files)
manage_data_truncate.gif
Affected versions
- Firefox 67.0b7 (20190331141835)
- Firefox 65.0 (20190124174741)
- Firefox 68.0a1 (20190403060632)
- Firefox 66.0.2 (20190326175229)
Affected platforms
- macOS 10.12.6
- Windows 10 x64
- Ubuntu 18.04 x64
Steps to reproduce
- Open Firefox and resize it to a quarter of the screen.
- Go to about:preferences#privacy.
- Select “Manage data” from Cookies and Site Data section.
Expected result
- The “Manage data” window is not truncated.
Actual result
- “Manage data” window is truncated.
Regression range
- This is not a recent regression as I can reproduce on 62.0a1 (20180605220158) as well. I will investigate further in case of an old regression.
Additional Notes
- Enlarging the browser and the “Manage data” window shows all buttons.
- Attached a screen recording with the issue.
|
Reporter | |
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
this seems to be not a regression. but seems implementation bug.
Triggerd by: 4f90a5f5fb16 Fischer.json — Bug 1309123 - Show persistent-storage permission request notification, r=florian
|
|
Reporter | |
Comment 2•5 years ago
|
||
Thank you Alice!
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Alice0775 White from comment #1)
this seems to be not a regression. but seems implementation bug.
Triggerd by: 4f90a5f5fb16 Fischer.json — Bug 1309123 - Show persistent-storage permission request notification, r=florian
This is confusing, because this commit doesn't change anything directly in the preferences, and wasn't what implemented this dialog, as far as I can tell.
Alice, I don't normally ask, but are you sure about the window you got?
|
|
||
Comment 4•5 years ago
|
||
Before landing of Bug 1309123, there is no "Site Data" section and button in about:preferences#privacy.
|
|
Assignee | |
Comment 5•5 years ago
|
||
(In reply to Alice0775 White from comment #4)
Before landing of Bug 1309123, there is no "Site Data" section and button in about:preferences#privacy.
Ah, it's because these changes enabled the browser.storageManager.enabled pref by default in nightly. The feature existed before then...
We deal with this more gracefully in the other exception dialogs etc. so I think we could improve something here... see bug 1128237 for how that worked. Then bug 1493844 changed it. Looks like we might just need to set contentPane on https://searchfox.org/mozilla-central/rev/14dc5b7d8a6da1854b2f9f33f1da77a97368cd54/browser/components/preferences/siteDataSettings.xul#29 .
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 6•5 years ago
|
||
Not really severe and not a recent regression, so let's just wontfix for 67.
|
|
Assignee | |
Comment 7•5 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8b7042135b72 add contentPane class to allow the site data settings dialog to scroll when the window height is constrained, r=jaws
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 10•5 years ago
|
||
Hello,
The issue is verified fixed using Firefox 68.0a1 (20190414214746) on Windows 10 x64, Ubuntu 18.04 x64, macOS 10.12.
Description
•