Closed Bug 1541048 Opened 5 years ago Closed 5 years ago

Missing padding between Landscape option and its icon in Print Preview

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: bmaris, Assigned: dao)

References

(Regression)

Details

(Keywords: polish, regression, Whiteboard: [qa-68b-p2])

Attachments

(2 files)

Screenshot showing the issue
2.26 KB, image/png
Details
Bug 1541048 - Restore margin between Landscape button and its icon in Print Preview. r=jaws
47 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • Firefox 67.0b7
  • Firefox 66.0.2
  • Latest Nightly 68.0a1
  • Firefox 64.0

Affected platforms

  • Windows (8.1, 10, 7)
  • Ubuntu 18.04 64bit

Unaffected platforms

  • macOS 10.13

Steps to reproduce

  1. Start Firefox
  2. Enter print preview
    (click hamburger menu -> click Print)

Expected result

  • All the buttons and menus are correctly displayed.

Actual result

  • Few pixels are missing between Landscape and its icon.

Regression range

Additional notes

  • macOS is not affected since it does not have Print Preview.
  • screenshot with the issue is attached.
  • not entirely sure if the regressor from above is the correct one.
Flags: needinfo?(dao+bmo)
Has Regression Range: --- → yes
Component: Toolbars and Customization → Theme
No longer depends on: 1493887
Flags: needinfo?(dao+bmo)
Priority: -- → P3
Regressed by: 1493887
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97cb70cd9c39
Restore margin between Landscape button and its icon in Print Preview. r=jaws

https://hg.mozilla.org/mozilla-central/rev/97cb70cd9c39

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Whiteboard: [qa-68b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: