Affected versions

• Firefox 66.0.2 (BuildId:20190326175229)
• Firefox 67.0b5 (BuildId:20190325125126)
• Firefox 68.0a1 (BuildId:20190327175114)

Unaffected versions

• Firefox 60.6.1esr (BuildId:20190322020346)

Affected platforms

• Ubuntu 18.04 64bit
• Windows 10 64bit
• macOS 10.12.6

Preconditions
Have a Master Password created.

Steps to reproduce

1. Launch Firefox.
2. Open the Hamburger menu.
3. Click the “Sign in to Sync” option.
4. Click the “Sign In” button and log in with your credentials.
5. Restart Firefox.
6. Click the “Disconnect” button.
7. Click the “Just Disconnect” button.
8. Click “Cancel” on the Master Password prompt.
9. Click “Disconnect” again.

Expected result

• The Sync account is disconnected after step 8 or the user has the possibility of repeating step 7 if he accidentally clicked the “Cancel” button from the Master Password prompt.

Actual result

• The account doesn't get disconnected and the following error message gets thrown inside the Browser Console every time the “Disconnect” button gets pressed if the user has clicked the “Cancel” button from the Master Password prompt previously:

Failed to sanitize
Exception { name: "NS_ERROR_ABORT", message: "User canceled master password entry", result: 2147500036, filename: "resource://gre/modules/crypto-SDR.js", lineNumber: 179, columnNumber: 0, data: null, stack: "decrypt@resource://gre/modules/crypto-SDR.js:179:26\n_decryptLogins@resource://gre/modules/storage-json.js:523:39\nfindLogins@resource://gre/modules/storage-json.js:416:19\nfindLogins@resource://gre/modules/LoginManager.jsm:401:26\ndeleteSyncCredentials@resource://services-sync/browserid_identity.js:351:36\nstartOver@resource://services-sync/service.js:843:19\nopenModalWindow@resource://gre/modules/Prompter.jsm:358:17\nopenPrompt@resource://gre/modules/Prompter.jsm:566:9\nnsIPrompt_promptPassword@resource://gre/modules/Prompter.jsm:783:14\npromptPassword@resource://gre/modules/Prompter.jsm:597:50\nencrypt@resource://gre/modules/crypto-SDR.js:78:38\nensureMPUnlocked@resource://services-sync/util.js:591:17\nunlockAndVerifyAuthState@resource://services-sync/browserid_identity.js:384:16\n", location: XPCWrappedNative_NoHelper }

Regression range

• Last good revision: a90972d695291bea4560ee5a8da77398ca9b42b1
• First bad revision: 1c6cfeb419c3157fc3dd6ae564358f7af8ca9cd1
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a90972d695291bea4560ee5a8da77398ca9b42b1&tochange=1c6cfeb419c3157fc3dd6ae564358f7af8ca9cd1
• Potential regressor: Bug 1409208

Additional Information

• I have attached a screencast for this issue

Hi Mark,

It seems that mozregression points out Bug 1409208 for causing this issue.

Can you please have a look?

Also, as an additional note:

• If restarting Firefox after step 8, the account is no longer displayed inside the Hamburger menu but it’s still present inside the about:preferences#sync page. I have attached a screenshot for this.

Untracking and marking as fix-optional for 67 given that the bug is unassigned, that we shipped with this regression since 62 and we are past our early beta cycle.

Taking - I'll ask eoger for a review since he helped review bug 1409208.

https://hg.mozilla.org/mozilla-central/rev/75f5acc4c2ac

Comment on attachment 9057188 [details]
Bug 1539784 - ensure the master-password is unlocked before disconnecting from sync.

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1409208
• User impact if declined: Users with a master-password enabled and not unlocked to try and disconnect sync will have a temporary bad time. Hopefully most such users will not hit this as they will unlock their master-password. And even if they don't, things get back to normal after the browser restarts - but it is a bit of a paper-cut.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: As described in the bug
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a very small patch which simply aborts the entire process if the master-password remains locked.
• String changes made/needed: None

I'd like to see it verified on Nightly before evaluating an uplift to beta.

This issue is verified fixed using Firefox 68.0a1 (BuildId:20190412093400) on Windows 10 64bit, macOS 10.12.6 and Ubuntu 14.04 64bit.

Comment on attachment 9057188 [details]
Bug 1539784 - ensure the master-password is unlocked before disconnecting from sync.

Low risk and verified by QA. Uplift accepted for 76 beta 11 given that we are promoting the use of logins and passwords via Lockbox and new Desktop entry points in 67, thanks.

https://hg.mozilla.org/releases/mozilla-beta/rev/37c5083230c5

This issue is verified fixed using Firefox 67.0b11 (BuildId:20190415085659) on Windows 10 64bit, macOS 10.12.6 and Ubuntu 14.04 64bit.