Text on Blacklist button from about:url-classifier is not centered
Categories
(Toolkit :: Safe Browsing, defect, P3)
Tracking
()
People
(Reporter: cfogel, Assigned: damien.feugas)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
Affected versions
- 66.0, 67.0b5, 68.0a1(2019-03-26)
Affected platforms
- Windows 10, macOS 10.14, Ubuntu 16.04;
Steps to reproduce
- Launch Firefox and access about:url-classifier
- Click on the Blacklist button from the list type section;
Expected result
- items are centered in the page;
Actual result
- the Blacklist text from the button is not centered horizontally;
Regression range
- will provide one asap;
Additional notes
- attached screenshot with the issue;
- as a reference, the [Start Searching] button bellow is properly centered;
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Running Mozregression tool indicates that this issue has been introduced in this pushlog (bug 1513298):
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a6cc9b822c1c1051961f8a293bc3e0331b8739d6&tochange=e57137ffb27d6f6b7c2a0575e9c46f770491088d
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7854ee8867a8 Select vertical align in about:url-classifier, r=dao
Comment 4•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Updated•5 years ago
|
Reporter | ||
Comment 5•5 years ago
|
||
Changes verified with 68.0a1 (2019-05-01) on Windows 10, macOS 10.13, Ubuntu 18.04.
While it's not as blatant, the text should still be shifted about 2 pixels down, to be better centered inside the button.
As discussed with :dimi on slack, reopening this issue for it.
Updated•5 years ago
|
Comment 6•5 years ago
|
||
I'd like to take up this issue.
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Hi Robert,
do you still plan to work on this bug?
Comment 8•5 years ago
|
||
(In reply to Cristian Fogel, QA [:cfogel] from comment #5)
Changes verified with 68.0a1 (2019-05-01) on Windows 10, macOS 10.13, Ubuntu 18.04.
While it's not as blatant, the text should still be shifted about 2 pixels down, to be better centered inside the button.As discussed with :dimi on slack, reopening this issue for it.
Please file a new bug. I'm closing this again to reflect that the patch fixing the main issue landed in 68.
Description
•