Affected versions

• 66.0-build 2, 66.0b14, 67.0a1(20190313100914)

Affected platforms

• Windows 10x64, macOS 10.13, macOS10.14, Ubuntu 18.04;

Steps to reproduce

1. Access about:url-classifier
2. Turn off the internet;
3. Click on the Trigger Update button for any of the google, google 4, mozilla providers;

Expected result

• an error message - code is displayed;

Actual result

• The following message is displayed:

download error
($error)

Regression range

• will provide one asap, if it is in fact a regression;

Additional notes

• attached screenshot with the issue;

Also reproducible on Fennec 66.0 build 2 on Android 8 & 9.

Hello, I've linked bellow the regression results:

• Last good: build_date: 2018-09-20 16:28:45.796000 changeset: 494efc7d8c29163ac544a584055329ce2d32d0b5
• First bad: build_date: 2018-09-20 16:34:00.903000 changeset: 7335fb70cb317329a19a7a273b22fbb987eeda38
• Potential regressor: bug 1486937

While checking for the regression range, builds in between have shown the message "error" instead of the error code or mentioned string.

@Jack mind taking a look and confirming this is the case?

https://hg.mozilla.org/mozilla-central/rev/884a5648d5f9

I have managed to reproduce this issue using Firefox 67.0a1 (20190314214219) on Windows 10 x64.
This issue is verified fixed using Firefox 68.0a1 (20190322101035) on Windows 10 x64, Ubuntu 18.04 x64, macOS 10.14.

Removing the ni? since it's no longer required.

Hi Ethan (Dimi is OOO), since 67 is marked as affected, should we consider uplifting this to Beta67? If yes, please nominate a patch for uplift.

Comment on attachment 9052234 [details]
Bug 1535307 - Remove an extra bracket when set update status in aboutUrlClassifier. r?gijs

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1486937
• User impact if declined: Internal code error will be shown on about:url-classifier in some use cases.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR is clearly defined in comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is only a two-line change of code to fix a JS syntax mistake. It won't affect any other code.
• String changes made/needed:

Comment on attachment 9052234 [details]
Bug 1535307 - Remove an extra bracket when set update status in aboutUrlClassifier. r?gijs

Fix for a JS syntax error, approved for 67 beta 7, thanks.

https://hg.mozilla.org/releases/mozilla-beta/rev/b4d3f8ae0274

The issue is verified fixed using Firefox 67.0b7 (20190331141835) on Windows 10 x64, Ubuntu 18.04 x64, macOS 10.13.