Closed Bug 1535272 Opened 5 years ago Closed 5 years ago

List tree and task tree need customElements.upgrade called on them

Categories

(Calendar :: Calendar Frontend, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

The calendar-list-tree and calendar-task-tree bindings contain a <tree>, which is now a custom element. We need to call customElements.upgrade on the tree, and I think doing so stops the annoying this.treebox is null message.

Attached patch 1535272-tree-upgrade-1.diff — — Splinter Review

I also discovered that calendar-list-tree has a field named "tree" and a property named "tree".

Attachment #9050928 - Flags: review?(philipp)
Attachment #9050928 - Flags: review?(philipp) → review+
Keywords: checkin-needed

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/af3e3d4899f5
Call customElements.upgrade on inner XUL tree of calendar tree bindings; r=Fallen

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.9
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: