Synced Tabs panel is blank in subsequent windows
Categories
(Firefox :: Sync, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox66 | --- | wontfix |
| firefox67 | + | verified |
| firefox68 | --- | verified |
People
(Reporter: Gabi, Assigned: markh)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
92.18 KB,
image/png
|
Details | |
|
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
syncedtabs.png
[Affected versions]:
- 67.0a1
- 66.0b14
[Affected platforms]:
- Windows 10 x64
- MacOS 10.12.16
- Ubuntu 16.4
[Steps to reproduce]:
- Launch Firefox
- Navigate to Customize
- Drag Forget button to the toolbar
- Click Forget button
- Click on Forget! button
- Go to Synced Tabs from View History, bookmarks and more menu
- Observe the Synced Tabs panel
[Expected result]:
- Sing in to Sync should be displayed under the Synced Tabs panel
[Actual result]:
- Synced Tabs panel is blank after using Forget about some browsing history
[Regression range]:
- Will return with the regression range asap
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 1•5 years ago
|
||
|
|
Reporter | |
Updated•5 years ago
|
|
||
Comment 3•5 years ago
|
||
Who should take this now that Paolo has left?
|
||
Comment 4•5 years ago
|
||
(In reply to Patricia Lawless from comment #3)
Who should take this now that Paolo has left?
Looks like Mark reviewed the patch, and this is sync-related, so let's move there and ask the Sync team to take a look.
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 5•5 years ago
|
||
It's actually worse than as described:
- Open Firefox, open "sync tabs", note the "setup sync" state.
- Open another top-level window, open "sync tabs" - it is blank.
Patch forthcoming.
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
||
Comment 7•5 years ago
|
||
[Tracking Requested - why for this release]:
Given comment #5, I think this is more serious than we initially thought, and wants uplifting. The patch as it is right now looks small enough.
Pushed by mhammond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5dfa26d0646 ensure new windows default to 'setup sync' state. r=eoger
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 10•5 years ago
|
||
Comment on attachment 9053192 [details]
Bug 1534699 - ensure new windows default to 'setup sync' state. r?eoger
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1482645
- User impact if declined: "Synced Tabs" panel may be blank
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very small patch, impact limited to sync ui
- String changes made/needed: None
|
||
Comment 11•5 years ago
|
||
The patch is small and seems well understood but since this is landed on Nightly and we have clear STRs from QA in comment #0, I would like our QA team to verify the fix on Nightly before and after uplifting to beta.
Also, given that we regressed that since 63, would it be possible to have an automatic test to prevent regressing it again in the future? Thanks
|
||
Updated•5 years ago
|
|
||
Comment 12•5 years ago
|
||
Hi, I managed to reproduce this issue in older versions of Firefox like Beta and Release but this issue no longer occurs in the Latest Nightly build 68.0a1 (2019-03-27), I verified this issue on Windows 10, Ubuntu and Mac OsX.
|
|
||
Comment 13•5 years ago
|
||
Comment on attachment 9053192 [details]
Bug 1534699 - ensure new windows default to 'setup sync' state. r?eoger
Low risk patch for a regression, verified by our QA on Nightly, uplift approved for 67 beta 6, thanks.
|
||
Comment 14•5 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 15•5 years ago
|
||
Hi, This issue is Verified as fixed in the latest Firefox Beta 67.0b6 on Windows 10, Ubuntu and Mac OsX, I will mark this issue accordingly.
Description
•