Closed
Bug 1534530
Opened 5 years ago
Closed 5 years ago
Remove some leftover references to RDF in comments of c-c
Categories
(MailNews Core :: Backend, enhancement)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 67.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(2 files, 1 obsolete file)
1.63 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
16.61 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
There are still some comments in code and other text files in c-c which mention RDF even though RDF was already removed from the place or is no longer relevant.
Remove unused nc: and rdf: namespace declarations in Thunderbird's XUL files.
Attachment #9050220 -
Flags: review?(jorgk)
Comment 3•5 years ago
|
||
Comment on attachment 9050461 [details] [diff] [review] 1534530-ldap.patch Review of attachment 9050461 [details] [diff] [review]: ----------------------------------------------------------------- ::: ldap/xpcom/TODO.txt @@ -99,5 @@ > needs to change: assume all attributes are binary, use some > heuristic to figure out if they're a string. I wonder how > ldapsearch does this. > > * grep for XXXs and fix the issues Another trailing space to be killed, or do more move into view then? @@ -102,5 @@ > > * grep for XXXs and fix the issues > > -rdf datasource > --------------- Hmm, you removed the heading without removing the points below it? Are they still an issue. Do they relate to RDF?
Attachment #9050461 -
Flags: review?(jorgk)
Yes, there are many trailing spaces in that file.
The points below the heading do not sound like particularly related to RDF so I kept them.
They just aren't implemented (or aren't to be implemented) in RDF.
Comment 5•5 years ago
|
||
Comment on attachment 9050461 [details] [diff] [review] 1534530-ldap.patch OK then.
Attachment #9050461 -
Flags: review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/60230bc80b94 remove mensions of RDF in ldap. r=jorgk
Comment 7•5 years ago
|
||
Attachment #9050220 -
Attachment is obsolete: true
Attachment #9050220 -
Flags: review?(jorgk)
Attachment #9051142 -
Flags: review?(jorgk)
Comment 8•5 years ago
|
||
Comment on attachment 9051142 [details] [diff] [review] 1534530-nc.patch - rebased OK, thanks.
Attachment #9051142 -
Flags: review?(jorgk) → review+
Updated•5 years ago
|
Keywords: leave-open → checkin-needed
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/36718c82bc31
remove unused nc: and rdf: namespace in Thunderbird's XUL files. r=jorgk
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 67.0
You need to log in
before you can comment on or make changes to this bug.
Description
•