Closed
Bug 1534256
Opened 5 years ago
Closed 5 years ago
Wrong support webpage is displayed after clicking the about:preferences help buttons
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 67
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | unaffected |
firefox66 | + | verified |
firefox67 | --- | verified |
People
(Reporter: emilghitta, Assigned: Gijs)
References
Details
(Keywords: regression)
Attachments
(2 files)
2.23 MB,
image/gif
|
Details | |
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta-
lizzard
:
approval-mozilla-release+
|
Details | Review |
Affected versions
- Firefox 67.0a1 (BuildId:20190311102806).
Unaffected versions
- Firefox 60.5.0esr (BuildId:20190124141046).
- Firefox 66.0b14 (BuildID:20190307095232).
- Firefox 65.0 (BuildId:20190124174741).
Affected platforms
- Windows 10 64bit.
- macOS 10.11.6
- Ubuntu 18.04 64bit.
Steps to reproduce
- Launch Firefox.
- Access the about:preferences page.
- Click the “Choose” button from the “Language and Appearance” section.
- Click the "Help" button.
Expected result
- The opened support webpage contains the information related to the section from where the help button was clicked.
- The following wepbage is displayed : Link
Actual result
- The following webpage is displayed: Link
Regression range
This seems to be a regression.
-
Potential regressor: Bug 1532685
Additional notes
- Please note that 66 will be affected as well (once Bug 1532685) gets uplifted.
- For further information regarding this issue, please observe the attached screencast.
Reporter | ||
Comment 1•5 years ago
|
||
Hi Gijs,
I think that the fix for Bug 1532685 may have introduced this regression.
Can you please have a look?
Thanks!
Flags: needinfo?(gijskruitbosch+bugs)
Reporter | ||
Updated•5 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Updated•5 years ago
|
tracking-firefox66:
--- → ?
Assignee | ||
Comment 2•5 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/af2e51990c3d actually open the right help topic page, r=jaws
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9049978 [details]
Bug 1534256 - actually open the right help topic page, r?jaws!
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1532685
- User impact if declined: The help button now opens only 1 tab (good! fixes regression from bug 1521040) but opens the generic sumo homepage in the user's locale instead of a topical page (bad!)
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment #0
- List of other uplifts needed: n/a
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): The patch itself is straightforward, but I said that last time... I took the opportunity to clean up a difference between windows/linux and mac, so now these help pages will always open in a new tab instead of a new window.
- String changes made/needed: nope
Attachment #9049978 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•5 years ago
|
Priority: -- → P1
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Comment on attachment 9049978 [details]
Bug 1534256 - actually open the right help topic page, r?jaws!
Fix for regression in 66, OK for uplift.
Attachment #9049978 -
Flags: approval-mozilla-release+
Attachment #9049978 -
Flags: approval-mozilla-beta?
Attachment #9049978 -
Flags: approval-mozilla-beta-
Comment 6•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Flags: qe-verify+
Comment 7•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Updated•5 years ago
|
QA Whiteboard: [qa-triaged]
Reporter | ||
Comment 8•5 years ago
|
||
This issue is verified fixed using Firefox 67.0a1 (BuildId:20190312095443) and Firefox 66.0 (BuildId:20190311211048) on Windows 10 64bit, macOS 10.12.6 and Ubuntu 16.04 32bit.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•