Closed Bug 1532688 Opened 5 years ago Closed 5 years ago

[MacOS] The minimum font size button is truncated

Categories

(Firefox :: Settings UI, defect, P5)

Product:
Firefox
Component:
Settings UI
Platform:
Desktop
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- verified

People

(Reporter: atrif, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot_17.png
42.47 KB, image/png
Details
Bug 1532688 - fix sizing of minimum font size dropdown, r?jaws
47 bytes, text/x-phabricator-request
Details | Review
Attached image Screenshot_17.png —

Affected versions

  • Firefox 66.0b13 (20190304101322)
  • Firefox 65.0.2 (20190225143501)
  • Firefox 67.0a1 (20190305092747)

Affected platforms

  • macOS 10.13.6

Steps to reproduce

  1. Open Firefox and go to about:preferences.
  2. Select “Advanced” under “Language and appearance”.
  3. Observe the button placed after “Minimum font size”.

Expected result

  • Bottom padding is not the same as for the top side.

Actual result

  • The “Minimum font size” button is truncated.

Regression range

  • I will provide a proper regression range ASAP.

Notes

  • Attached a screenshot with the issue.
Has Regression Range: --- → no
Has STR: --- → yes
Blocks: 1532735

Please see below the pushlog:

Last good revision: 8991d660f20e3eea652e060c30e17670b45a9257 (2018-11-20)
First bad revision: fbd97100c83cc07705244725a3245e6d14bbe9cf (2018-11-21)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8991d660f20e3eea652e060c30e17670b45a9257&tochange=fbd97100c83cc07705244725a3245e6d14bbe9cf

Has Regression Range: no → yes
Keywords: regressionwindow-wanted → regression

(In reply to Alexandru Trif from comment #1)

Please see below the pushlog:

Last good revision: 8991d660f20e3eea652e060c30e17670b45a9257 (2018-11-20)
First bad revision: fbd97100c83cc07705244725a3245e6d14bbe9cf (2018-11-21)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8991d660f20e3eea652e060c30e17670b45a9257&tochange=fbd97100c83cc07705244725a3245e6d14bbe9cf

I narrowed this down further. Looks like bug 1429940 broke this. This regressed with 65, but it's a bit late to fix this for 66, so let's try for 67...

The menulist has a min-height: of 20px (set in https://searchfox.org/mozilla-central/rev/fbb251448feb7276f9b1d0a88f9c0cb1cd144ce4/toolkit/themes/osx/global/menulist.css#15-18 ), which is overriding the height: of 30px (set in https://searchfox.org/mozilla-central/rev/fbb251448feb7276f9b1d0a88f9c0cb1cd144ce4/browser/themes/shared/incontentprefs/preferences.inc.css#796-800 ).

I actually don't know why the changes in bug 1429940 would have tripped this. Looks like a XUL bug to me. However, I have a patch...

Assignee: nobody → gijskruitbosch+bugs
Blocks: 1429940
Status: NEW → ASSIGNED
status-firefox66: affected → wontfix
Priority: -- → P5
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7450a570330e
fix sizing of minimum font size dropdown, r=jaws

https://hg.mozilla.org/mozilla-central/rev/7450a570330e

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Verified as fixed on Firefox Nightly 67.0a1 (2019-03-14) on Mac OS X 10.14 and on Mac OS X 10.13.6.

Status: RESOLVED → VERIFIED
status-firefox67: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: