[Affected versions]:

• Fx 60.5.3

[Affected platforms]:

• Windows 10 x64
• Ubuntu 16.04 x64
• macOS 10.14

[Steps to reproduce]:

1. Create a new profile and launch Fx with it.
2. In the Firefox folder, create the distribution folder and copy the attached policy.json file.
3. Close Firefox and re-open it again with the same profile.
4. Access the about:addons page.

[Expected result]:

• The page should load without any issues.

[Actual result]:

• The page remains stuck in an infinite loading animation.

[Additional notes]:

• This issue does not occur on the latest beta (Fx66.0b13).
• Clicking the 'Extensions' option ends the infinite 'Loading' animation.
• Please note that this issue was reproduced on an intermediary build from treeherder(ESR buildID: 20190304105950), while testing the uplift of the Disable Addons policy (bug 1525357).

We should probably fix this before shipping 60.6 unless I'm misunderstanding the severity here.

So this isn't really an infinite load. The buttons on the left work to navigate to the correct tabs.

The problem is that the discovery pane is trying to load (which is odd because we have code that deliberately doesn't load it).

Since this isn't a new problem, I don't consider it a blocker, but I'm going to try to put a safe fix together.

This bug was explicitly fixed here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1132971

So this is a regression.

Trunk has an explicit check for this case that was added as part of this bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=1311145

This was post ESR, but I'm not sure what broke ESR, but the new code is the correct fix.

This is a very contained low risk fix if we want to take it.

Comment on attachment 9049226 [details]
Bug 1532674 - Use extensions view if discover is disabled.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Usability issue in policies found by test.
• User impact if declined: If policy is set to block xpinstall, when opening addons manager, a spinner shows
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch already landed on release and has been working for a while.
• String or UUID changes made by this patch:

Obviously this is your call, Ryan,but this is reviewed and had been tested as part of release for a while.

Comment on attachment 9049226 [details]
Bug 1532674 - Use extensions view if discover is disabled.

Backports a simple check which has been shipping to release since 61 to avoid a confusing UI situation for users with discover disabled. Approved for 60.6esr.

https://hg.mozilla.org/releases/mozilla-esr60/rev/017078fb9b23

Tested using Fx 60.6.0ESR on Ubuntu 16.04, macOS 10.14 and Windows 10 x64. The about:addons page now loads without any issues with the 'extensions' section selected.