Closed Bug 1531812 Opened 5 years ago Closed 1 year ago

Remove remaining mozRTC* stuff (mozRTCPeerConnection, mozRTCIceCandidate, mozRTCSessionDescription)

Categories

(Core :: WebRTC: Signaling, task, P3)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
relnote-firefox --- 113+
firefox113 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

(Blocks 3 open bugs)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

No description provided.
Rank: 35
Priority: -- → P4

It doesn't look like we mention that these are available in the first place. Almost pointless to add them considering they are now being removed, but hey ;-)

Keywords: dev-doc-needed

I'd like to say yes—with the exception of navigator.mozGetUserMedia (see bug 1279936)—but from bug 1155923 comment 5 I'm not sure. That was 4 years ago, but unfortunately we don't have telemetry on this.

The safe way to go about it might be to gather telemetry on mozRTCPeerConnection usage first, to know what breakage to expect.

That said, even having a telemetry number on mozRTCPeerConnection usage would not tell us about breakage, because it wouldn't distinguish

var RTCPeerConnection = window.webkitRTCPeerConnection || window.mozRTCPeerConnection || window.RTCPeerConnection; // OK!

from

var RTCPeerConnection = window.webkitRTCPeerConnection || window.mozRTCPeerConnection; // Would break!

I don't see a way to detect actual breakage numbers. That said, a ballpark mozRTCPeerConnection usage number would be instructive if it's really low.

Nico, is this something we could add to bug 1528078 which you'd expressed interest in tackling?

Depends on: 1155923
Flags: needinfo?(jib) → needinfo?(na-g)
Keywords: site-compat

Yes, I will be tackling it in bug 1528078.

Flags: needinfo?(na-g)
Priority: P4 → P3
Type: enhancement → task
No longer depends on: 1609254

Turns out we do have telemetry probe for this: 2.7% of peer connections use moz-prefix. Breakage may be even lower based on comment 3.

  • 0.218% of pageloads called any of the moz-prefixed peer connection methods
  • 8% of pageloads call the non-deprecated RTCPeerConnection constructor (from chromestats, since we don't have counters for that)
Blocks: 881211
Severity: normal → S3

Taking this; it is about time, and low-hanging fruit.

Assignee: nobody → docfaraday

Depends on D168415

Try looks fine.

Need to make a pull request here to get rid of this mozRTC stuff:

https://github.com/mozilla/webrtc-landing

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc4c2ac428b0
Remove remaining mozRTC stuff. r=jib,webidl,smaug

Backed out for causing build bustages on PeerConnectionImpl.cpp

mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland

Flags: needinfo?(docfaraday)
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f031686043e
Remove remaining mozRTC stuff. r=jib,webidl,smaug
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8e892e3e742
Remove remaining mozRTC stuff. r=jib,webidl,smaug
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Regressions: 1823863
Regressions: 1824710
Regressions: 1824735

Release Note Request (optional, but appreciated)
[Why is this notable]:
Sadly, there are still services that are using this.
[Affects Firefox for Android]:
Yes.
[Suggested wording]:
Removed the long-deprecated mozRTCPeerConnection, mozRTCIceCandidate, and mozRTCSessionDescription types.
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
Flags: needinfo?(docfaraday)

Added to the Fx113 Nightly relnotes. I added an additional line saying that sites should use the non-prefixed variants instead.

Regressions: 1829625

FYI MDN docs work for this can be tracked in https://github.com/mdn/content/issues/26146. There wasn't much to do in this case other than a release note mentioning the removal.

No longer depends on: 1561007
Blocks: unprefix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: