The Reload button has the icon misplaced in Customize mode
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | wontfix |
firefox66 | + | verified |
firefox67 | --- | verified |
People
(Reporter: csasca, Assigned: bgrins)
References
Details
(Keywords: regression)
Attachments
(2 files)
11.60 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- Firefox 65.0.1
- Firefox Beta 66.0b9
- Firefox DevEdition 66.0b10
- Firefox Nightly 67.0a1 (2019-02-25)
Affected platforms
- Windows 7 (x64)
- Windows 10 (x64)
- Ubuntu 18.04 (x64)
- macOS 10.14
Steps to reproduce
- Start Firefox
- Enter the Customize page
- Drag and drop the reload button in the list
Expected result
- There are no glitches with the button.
Actual result
- The reload icon is misplaced.
Regression range
- I will get back with a regression asap.
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
- Last good revision: efa49008bfc788e3354d6150eab71a7f105e3102
- First bad revision: 8f7476054232c929476c1a5112bb855f6ba7612f
It looks like 1507875 is causing the regression.
Comment 2•5 years ago
|
||
[Tracking Requested - why for this release]:
user-visible regression in a recent release.
Brian, can you take a look, please? :-)
(I expect the stop/reload button is special because it's a toolbaritem instead of a toolbarbutton, and contains only 1 visible item at a time, and because it's in the toolbar by default we didn't notice it -- but it'd be good to check that the bookmarks toolbar items look OK still.)
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9a0cb62184d Center align the reload button in customize mode r=Gijs
Comment 5•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 6•5 years ago
|
||
Gijs do you want to request beta uplift since Brian is out this week?
Comment 7•5 years ago
|
||
I have reproduced this bug with Nightly 67.0a1 (2019-02-25) on Windows 7, 64 Bit. This bug's fix is verified with latest Nightly!
Build ID : 20190304093752
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
Comment 8•5 years ago
|
||
Comment on attachment 9046961 [details]
Bug 1530288 - Center align the reload button in customize mode
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1507875
- User impact if declined: odd-looking reload button when moved to palette
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Check styling of reload/stop button in customize mode in toolbar, palette and overflow panel
- List of other uplifts needed: n/a
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): CSS-only change
(Note that there are extensive tests for customize mode, but this issue is a styling one so automated tests don't catch it.)
- String changes made/needed: no
Comment 9•5 years ago
|
||
Comment on attachment 9046961 [details]
Bug 1530288 - Center align the reload button in customize mode
CSS tweak for customize menu. OK for beta 14 uplift.
Comment 10•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Comment 11•5 years ago
|
||
I managed to reproduce the issue on an older version of Nightly (2019-02-25) on Windows 10 x64.
I retested everything using latest Nightly 67.0a1 and beta 66.0b14 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.14, but the bug is not reproducing anymore.
Description
•