Closed Bug 1529874 Opened 5 years ago Closed 5 years ago

Update the "View History sidebar" button to "Hide History sidebar" if sidebar is enabled

Categories

(Firefox :: Menus, enhancement, P5)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1533533
Tracking Status
firefox-esr60 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- affected

People

(Reporter: cfogel, Assigned: jawad)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Affected versions

  • 66.0b10, 65.0.1, 67.0a1 (2019-02-21)

Affected platforms

  • Windows 10; Ubuntu 18.04, macOS 10.13;

Steps to reproduce

  1. Launch Firefox and enable the History sidebar;
  2. Click on the [View history saved bookmarks, and more] button;
  3. Click on the History option;

Actual result

  • The "View History sidebar" item is displayed;

Enhancement suggestion

  • The "Hide History and sidebar" item should be displayed;

Regression range

  • not a regression;

Additional notes

  • older versions had the option listed as just "History" listed so it wasn't an issue;
  • the reasoning is that once enabled, there isn't a clear indicator in the menus for closing, checkmark text or anything.

I believe this is handled under menus.

Just to note, the "View Bookmarks Sidebar" option under bookmarking does change to "Hide..."

Component: Bookmarks & History → Menus
Priority: -- → P5
Whiteboard: [good first bug]

Hey,

Can I work on this issue? I am new to Open Source and want to contribute for the first time.

Hi, I am willing to work on this, Please assign it to me.

Flags: needinfo?(jaws)

(In reply to Syeda Asra Arshia Qadri [:aqadri] from comment #2)

Hey,

Can I work on this issue? I am new to Open Source and want to contribute for the first time.

(In reply to Jawad Ahmed [:jawad] from comment #3)

Hi, I am willing to work on this, Please assign it to me.

Sorry, but bugs are only assigned when patches are attached. @Jawad, you're currently assigned to 14 open bugs (including this one). That is far too many at one time and takes away opportunities from other new contributors.

Assignee: ijawadak → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jaws)
Assignee: nobody → ijawadak
Status: NEW → ASSIGNED
Attachment #9051869 - Attachment description: Bug 1529874 - Update the 'View History' sidebar button to 'Hide History sidebar' if sidebar is enabled. r=johannh → Bug 1529874 - Update the 'View History' sidebar button to 'Hide History sidebar' if sidebar is enabled. r=jaws

Fixed in bug 1533533. We are tracking a regression also in bug 1547614.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: