Closed Bug 1527891 Opened 5 years ago Closed 5 years ago

[Content Blocking] Missing labels for Cryptominers and Fingerprinters in the Control Center (door hanger)

Categories

(Firefox :: Protections UI, defect, P1)

Product:
Firefox
Component:
Protections UI
Version:
67 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox-esr60 --- disabled
firefox65 --- disabled
firefox66 --- disabled
firefox67 --- verified
firefox68 --- verified

People

(Reporter: cgeorgiu, Assigned: johannh)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1527891 - Fix copy-paste error in browser-contentblocking.js, update category labels when pref changes for fp and cm. r=ewright
47 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • latest Nightly 67.0a1

Affected platforms

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 16.04 x64

Prerequisites
Launch Firefox on a clean profile.
Set the following prefs to true in about:config

  • privacy.trackingprotection.cryptomining.enabled
  • privacy.trackingprotection.fingerprinting.enabled
  • browser.contentblocking.cryptomining.preferences.ui.enabled
  • browser.contentblocking.fingerprinting.preferences.ui.enabled

Steps to reproduce

  1. Uncheck the "Fingerprinters" item in about:preferences#privacy.
  2. Access the https://senglehardt.com/test/trackingprotection/test_pages/fingerprinting_and_cryptomining.html and refresh the test page.
  3. Restart the browser.
  4. Check again the "Fingerprinters" item in about:preferences#privacy.
  5. Refresh the test page.
  6. Click on the Shield icon and inspect the "Fingerprinters" item from the door hanger.

Expected result

  • Fingerprintres is displayed with the "Blocking >" status in the door hanger.

Actual result

  • The "Blocking >" status is missing in the door hanger.

Regression range

  • Not a regression, I was able to reproduce this on 67.0a1 (2019-02-12) as well, when this feature first landed.

Additional notes

  • This seems to be an UI issue in the Control Center since the Fingerprinting is correctly blocked on the test page, and in the Application Menu.
Severity: normal → major

Hah, very well spotted, thank you! Will be a quick fix...

Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efb70f3ce800
Fix copy-paste error in browser-contentblocking.js, update category labels when pref changes for fp and cm. r=ewright

https://hg.mozilla.org/mozilla-central/rev/efb70f3ce800

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Flags: qe-verify+

Hello,

Confirming this issue as verified fixed on 67.0b12(20190418160535)and Nightly 68.0a1(20190419094745). Checked on Windows 10x64, Ubuntu 16.04x64 and macOS 10.13.

Status: RESOLVED → VERIFIED
status-firefox67: fixed → verified
status-firefox68: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: