Affected versions

• 66.0b7
• 67.0a1(2019-02-12)

Affected platforms

• Windows 10 x64
• macOS 10.13
• Ubuntu 16.04 x64

Steps to reproduce

1. Launch FF.
2. Open multiple websites in different tabs.
3. Open about:performance.
4. Click to drop down each section from each website.

Expected result

• Clicking on the expand button for each website's section, should automatically drop down and present the user with all the sub-frames and cookies.

Actual result

• Clicking on the expand button for each website's section, renders no action in the first ~10 seconds.

*After that, the whole page becomes faulty:
-sub-frames as well as their parent website become duplicated or even tripled
-list of sub-frames is in wrong order for each section
-ultimately the page freezes complete

Regression range
*7:22.67 INFO: Last good revision: c28522aaf3918c5f556c65432f8bf14a65bff65a
*7:22.67 INFO: First bad revision: 33e42b897fb122df45448648f6a1d2e1a62ce083
*7:22.67 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c28522aaf3918c5f556c65432f8bf14a65bff65a&tochange=33e42b897fb122df45448648f6a1d2e1a62ce083

• Potentially regressed by: Bug 1501458

Additional notes

• Issue IS NOT present in FF 65.0.1

Hello Dimi,

It seems that Mozregression pointed out Bug 1501458 as a potential cause for this issue.

The error happened because aboutPerformance provided an unused
parameter to Classify API which is removed in Bug 1501458.

Check tracking protection tables via Classify API is not supported now.
We should use asyncClassifyLocalWithFeatures API instead.

https://hg.mozilla.org/mozilla-central/rev/2877c6fff181

Glad we caught this! Is there any extra test coverage you could add here?

I'd like to avoid shipping this regression in 66. Can you request uplift?

Comment on attachment 9043889 [details]
Bug 1527658 - Use asyncClassifyLocalWithFeatures API in aboutPerformance. r?baku

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1501458

User impact if declined

about:performance will display abnormally

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

1. Launch FF.
2. Open multiple websites in different tabs.
3. Open about:performance.
4. Click to drop down each section from each website.

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

it is not risky because we don't change any behavior in URL classifier, just replace the deprecated API with the new API

String changes made/needed

No

Hello,

Confirming this issue as verified fixed in 67.0a1 (2019-02-22) (buildID:20190222081112). Verified on Win 10x64, macOS 10.12 and Ubuntu 16.04.

Comment on attachment 9043889 [details]
Bug 1527658 - Use asyncClassifyLocalWithFeatures API in aboutPerformance. r?baku

Fix for regression in about:performance page layout, verified in nightly.
OK for uplift for beta 11.

Hi, this is not applying cleanly on beta, I got graft conflicts:
grafting 528156:2877c6fff181 "Bug 1527658 - Use asyncClassifyLocalWithFeatures API in aboutPerformance. r=baku"
merging toolkit/components/aboutperformance/content/aboutPerformance.js
warning: conflicts while merging toolkit/components/aboutperformance/content/aboutPerformance.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue

Dimi, please provide a patch for beta. Thank you.

Patch for beta uploaded!

https://hg.mozilla.org/releases/mozilla-beta/rev/a81551b6fd6b

Hello,

Confirming this issue as verified fixed in 66.0b12(buildID:20190228180200). Verified on Win 10x64, macOS 10.12 and Ubuntu 16.04.

Please specify a root cause for this bug. See :tmaity for more information.