Make Search suggestion on dark theme easier to distinguish in "Search for [suggestion] with" string
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
People
(Reporter: cfogel, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
3.64 KB,
image/png
|
Details |
Affected versions
- 66.0b7, 65.0b, 67.0a1(2019-02-11);
Affected platforms
- Windows 8.1, macOS 10.14, Ubuntu 16.04;
Steps to reproduce
- Launch Firefox;
- Type something in the awesome bar;
- Observe the "Search for [something] with";
Enhancement suggestion
- apply styling to the search therm so it's easy to distinguish;
Actual result
- the [something] word has no styling on the dark theme;
Regression range
- not a regression, post Ffx v.60 seems to take in account the dark theme changes for the search suggestions;
Additional notes
- on the Default/Light theme the therm stands out(string is grey, therm is black);
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Moving to theme because in the end this boils down to the weight of the text in dark mode... Alternatively we could find a different way to distinguish text here, considered it's very small.
Comment 2•5 years ago
|
||
Hi, I am willing to work on it, Please assign it to me.
Updated•5 years ago
|
Comment 3•5 years ago
|
||
This bug should only get assigned when a patch is attached.
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Updating this to depend on bug 1561894, since it was decided that feature would be incorporated into the existing Urlbar and not just the new design. Bug 1561894 removes the string referenced in this bug, so I'm marking this as resolved.
Updated•5 years ago
|
Reporter | ||
Comment 6•5 years ago
|
||
Confirmed with 70.0a1 (2019-08-27).
Thank you for the info Harry!
Updated•2 years ago
|
Description
•