Closed Bug 1527257 Opened 5 years ago Closed 5 years ago

Make Search suggestion on dark theme easier to distinguish in "Search for [suggestion] with" string

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- verified

People

(Reporter: cfogel, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Affected versions

  • 66.0b7, 65.0b, 67.0a1(2019-02-11);

Affected platforms

  • Windows 8.1, macOS 10.14, Ubuntu 16.04;

Steps to reproduce

  1. Launch Firefox;
  2. Type something in the awesome bar;
  3. Observe the "Search for [something] with";

Enhancement suggestion

  • apply styling to the search therm so it's easy to distinguish;

Actual result

  • the [something] word has no styling on the dark theme;

Regression range

  • not a regression, post Ffx v.60 seems to take in account the dark theme changes for the search suggestions;

Additional notes

  • on the Default/Light theme the therm stands out(string is grey, therm is black);

Moving to theme because in the end this boils down to the weight of the text in dark mode... Alternatively we could find a different way to distinguish text here, considered it's very small.

Component: Address Bar → Theme

Hi, I am willing to work on it, Please assign it to me.

Flags: needinfo?(lhenry)
Assignee: nobody → ijawadak
Flags: needinfo?(lhenry)

This bug should only get assigned when a patch is attached.

Assignee: ijawadak → nobody
Priority: -- → P3

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.

Regressed by: 1453722
Depends on: urlbar-update-1

Updating this to depend on bug 1561894, since it was decided that feature would be incorporated into the existing Urlbar and not just the new design. Bug 1561894 removes the string referenced in this bug, so I'm marking this as resolved.

Status: NEW → RESOLVED
Closed: 5 years ago
Depends on: 1561894
No longer depends on: urlbar-update-1
Resolution: --- → FIXED
Assignee: nobody → htwyford
Target Milestone: --- → Firefox 70

Confirmed with 70.0a1 (2019-08-27).
Thank you for the info Harry!

Status: RESOLVED → VERIFIED
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: