"WebDriver:MinimizeWindow" and "WebDriver:FullscreenWindow" don't initially restore normal window state
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(firefox66 fixed)
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I have seen this yesterday while working on bug 1521028. Both the commands do not restore the normal window state before entering the requested state. It means that it causes side-effects, and test failures for tests I'm going to add on bug 1521028.
As written in the WebDriver specification the window has to be restored or to unhide, which implies to me that it also has to be changed from a maximized to a normal state:
|
Assignee | |
Comment 1•5 years ago
|
||
I want to land this separate to have it shipped a bit faster given that the work on bug 1521028 would still take at least one more day.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
The window should always be restored first to the normal window state,
before a special state like fullscreen or minimized can be entered.
Right now this isn't done when going from a maximized window into
fullscreen mode, or when minimizing the window.
|
|
Assignee | |
Comment 4•5 years ago
|
||
I don't understand what's happening here in the try build for MacOS opt builds, and the wpt1 and wpt2 test jobs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8df7e11f47b335fffa2b6f890d9479607fe02bbe
Why are the web-audio tests failing on that platform and build combination only? When I run this all locally I don't see any failures for web-audio.
I talk to Nils and he suggested to ask Paul about it. Paul, when you have a bit of time (once you are back) could you please have a look? Thanks!
|
|
Assignee | |
Comment 5•5 years ago
|
||
Ok, I can actually replicate this problem when using the Firefox binary from the try build as created by TaskCluster:
https://queue.taskcluster.net/v1/task/TL4UGw1vTWusgnOVzm3OQA/runs/0/artifacts/public/build/target.dmg
Maybe there is something busted with the artifact build? To prove that submitted another try build with a full build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=441ab2717ff9423a6a09c5972612239d9bdae101
|
|
Assignee | |
Comment 6•5 years ago
|
||
Ok, that full try build was successful. So it's most likely that there was a problem with the generated artifact build, or the commit is was based off, and a patch for those failures landed afterward.
This is safe to review and land.
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4740a865552 [marionette] Restore maximized window first before entering fullscreen or minimizing the window. r=ato
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Updated•1 year ago
|
Description
•