Closed Bug 1521483 (tb-burn-xul-grids) Opened 5 years ago Closed 4 years ago

[meta] Remove Thunderbird related XUL grid layout usage

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
85 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: mkmelin, Unassigned)

References

Details

(Keywords: meta)

+++ This bug was initially created as a clone of Bug #1520625 +++

According to #maildev

13:10:40 - ntim: Paenglab_work: So employees have not planned anything internally yet, but I suspect they will in the coming months as part of the XUL removal (maybe at the same time or after XUL flexbox removal). Anyway, I've been working through mozilla-central usages and I found out that many of the usages don't need to be grids (mainly those with fixed-width columns or fixed-height rows, and single row layouts).

Blocks: 1525737
No longer depends on: burn-xul-grids

Richard, could you make a start? Looks like the conversion is not so hard, see:
d599d1a73a3a Tim Nguyen — Bug 1525747 - Remove XUL grid layout from browser/components/preferences/sanitize.xul. r=Gijs
760191b55ab3 Tim Nguyen — Bug 1525739 - Remove XUL grid layout from browser/base/content/sanitize.xul. r=Gijs

Flags: needinfo?(richard.marti)

(In reply to Tim Nguyen :ntim from comment #2)

Those two should be the easier ones to start with:

This is not so simple as we need to convert https://dxr.mozilla.org/comm-central/source/comm/calendar/base/content/preferences/general.xul#144 too because they are in a deck.

(In reply to Jorg K (GMT+1) from comment #3)

Richard, could you make a start? Looks like the conversion is not so hard, see:
d599d1a73a3a Tim Nguyen — Bug 1525747 - Remove XUL grid layout from browser/components/preferences/sanitize.xul. r=Gijs
760191b55ab3 Tim Nguyen — Bug 1525739 - Remove XUL grid layout from browser/base/content/sanitize.xul. r=Gijs

This was already on my radar. :-)

Flags: needinfo?(richard.marti)
Depends on: 1527003
Depends on: 1532234
Depends on: 1534249
No longer blocks: 1536028
Depends on: 1536028
Depends on: 1536030
Depends on: 1536873
Depends on: 1537729

All the grid layouts in Thunderbird:

comm/calendar/base/content/calendar-task-view.xul
comm/calendar/base/content/calendar-month-base-view.js
comm/calendar/base/content/dialogs/calendar-error-prompt.xul
comm/calendar/base/content/dialogs/calendar-event-dialog-attendees.xul
comm/calendar/base/content/dialogs/calendar-event-dialog-recurrence.xul
comm/calendar/base/content/dialogs/calendar-print-dialog.xul
comm/calendar/base/content/dialogs/calendar-properties-dialog.xul
comm/calendar/base/content/dialogs/calendar-subscriptions-dialog.xul
comm/calendar/base/content/dialogs/calendar-summary-dialog.xul
comm/calendar/base/content/preferences/alarms.xul
comm/calendar/base/content/preferences/general.xul
comm/calendar/base/content/preferences/views.xul
comm/calendar/lightning/content/lightning-item-iframe.xul
comm/calendar/resources/content/calendarCreation.xul
comm/calendar/resources/content/datetimepickers/datetimepickers.js
comm/calendar/resources/content/publishDialog.xul
comm/chat/content/chat-tooltip.js
comm/mail/components/compose/content/dialogs/EdAdvancedEdit.xul
comm/mail/components/compose/content/dialogs/EdColorProps.xul
comm/mail/components/compose/content/dialogs/EdDictionary.xul
comm/mail/components/compose/content/dialogs/EdHLineProps.xul
comm/mail/components/compose/content/dialogs/edImage.inc.xul
comm/mail/components/compose/content/dialogs/EdInsertMath.js
comm/mail/components/compose/content/dialogs/EdInsertTable.xul
comm/mail/components/compose/content/dialogs/EdInsertTOC.xul
comm/mail/components/compose/content/dialogs/EdReplace.xul
comm/mail/components/compose/content/dialogs/EdSpellCheck.xul
comm/mail/components/compose/content/dialogs/EdTableProps.xul
comm/mail/base/content/editContactPanel.inc.xul
comm/mail/base/content/FilterListDialog.xul
comm/mail/base/content/msgHdrView.inc.xul
comm/mail/components/accountcreation/content/emailWizard.xul
comm/mail/components/addrbook/content/abContactsPanel.xul
comm/mail/components/im/content/addbuddy.xul
comm/mail/components/im/content/imAccountWizard.xul
comm/mail/components/im/content/joinchat.xul
comm/mail/components/preferences/connection.xul
comm/mail/components/preferences/cookies.xul
comm/mail/components/preferences/display.inc.xul
comm/mail/components/preferences/fonts.xul
comm/mail/components/preferences/messengerLanguages.xul
comm/mail/components/preferences/receipts.xul
comm/mailnews/addrbook/prefs/content/pref-directory-add.xul
comm/mailnews/base/content/folderProps.xul
comm/mailnews/base/content/msgAccountCentral.xul
comm/mailnews/base/content/subscribe.xul
comm/mailnews/base/content/virtualFolderProperties.xul
comm/mailnews/base/prefs/content/AccountWizard.xul
comm/mailnews/base/prefs/content/am-copies.inc.xul
comm/mailnews/base/prefs/content/am-identity-edit.xul
comm/mailnews/base/prefs/content/am-junk.xul
comm/mailnews/base/prefs/content/am-main.xul
comm/mailnews/base/prefs/content/am-server-advanced.xul
comm/mailnews/base/prefs/content/am-server.xul
comm/mailnews/base/prefs/content/am-smtp.xul
comm/mailnews/base/prefs/content/SmtpServerEdit.xul
comm/mailnews/base/search/content/CustomHeaders.xul
comm/mailnews/base/search/content/FilterEditor.xul
comm/mailnews/compose/content/sendProgress.xul
comm/mailnews/extensions/mdn/content/am-mdn.xul
comm/mailnews/extensions/newsblog/content/feed-subscriptions.xul
comm/mailnews/extensions/newsblog/content/feedAccountWizard.xul
comm/mailnews/extensions/smime/content/msgCompSecurityInfo.xul
comm/mailnews/import/content/importDialog.xul

I have a patch for comm/calendar/base/content/preferences/

Can you add block this bug for future reference so we can keep track and don't overlap the files?

Flags: needinfo?(richard.marti)
Depends on: 1538485
Flags: needinfo?(richard.marti)
Depends on: 1542681
Depends on: 1542682
Depends on: 1544303
Depends on: 1545907
Depends on: 1545076
Depends on: 1545908
No longer blocks: 1546278
Depends on: 1546278
Depends on: 1546279
Depends on: 1546280
Depends on: 1546281
Depends on: 1546282
Depends on: 1546283
Type: defect → task
Depends on: 1547999
Depends on: 1548012
Depends on: 1548226
Depends on: 1548094
Depends on: 1548233
Depends on: 1548234
Depends on: 1548235
Depends on: 1557216
Depends on: 1557219
Depends on: 1557224
Regressions: 1561390

There are a few grids not covered here yet, especially in editor/ and calendar/:
https://searchfox.org/comm-central/search?q=%3Cgrid&case=false&regexp=false&path=

Yeah, I am working on it. Will be done in the next 2 to 3 weeks.

Depends on: 1568021
Depends on: 1568189
Depends on: 1568224
Depends on: 1568311
Depends on: 1568321
Depends on: 1568480
Depends on: 1568504
Depends on: 1568660
Depends on: 1569562
Depends on: 1569552
Depends on: 1569919
Depends on: 1569925
Depends on: 1580247
Depends on: 1580251
Depends on: 1580253
No longer depends on: 1580251
Depends on: 1580715
Depends on: 1580717
Depends on: 1580719
Depends on: 1581514
Depends on: 1581534
Depends on: 1581558
Depends on: 1581725
Depends on: 1581754
Depends on: 1582425
Depends on: 1582424
Depends on: 1582718
No longer blocks: 1582717
Depends on: 1582717
Depends on: 1583520
Depends on: 1585244
Depends on: 1586371
Depends on: 1632451
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1677427
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.