[css-logical] Implement the border-{block,inline}-{color,style,width} shorthands
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
21.01 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9036643 [details] [diff] [review] [css-logical] Implement the border-{block,inline}-{color,style,width} shorthands Review of attachment 9036643 [details] [diff] [review]: ----------------------------------------------------------------- If you could annotate the failures in the ini files it'd be amazing, other than that looks good :)
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/009cf5f885ba [css-logical] Implement the border-{block,inline}-{color,style,width} shorthands. r=emilio
|
|
Assignee | |
Comment 4•5 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)
If you could annotate the failures in the ini files it'd be amazing, other
than that looks good :)
Meh, there are probably dozens of these so it doesn't seem worth my time
to annotate them. We should probably just fix bug 1520396 to make
the tests succeed instead, assuming there's consensus about how to
serialize shorthands now.
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
||
Comment 6•5 years ago
|
||
Backed out changeset 009cf5f885ba (Bug 1520236) for multiple failures in logical-box-border-color-visited-link-002.html
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=520494fe4d64b304a9b73195a32331b82ffbee3d&selectedJob=222270730
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222306797&repo=mozilla-inbound&lineNumber=9580
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d7a79aa38e7e6583333c703b2ad8dbb885c7b3
|
||
Comment 7•5 years ago
•
|
||
Mats, you'll want the changes in bug 1520598 comment 6 when relanding. (direct link to that patch: attachment 9037091 [details] [diff] [review])
(feel free to just merge that in with your main patch here; it's a trivial bonus change)
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 8•5 years ago
|
||
Thanks Daniel. I'll reland with that change...
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/47d3dbd969f5 [css-logical] Implement the border-{block,inline}-{color,style,width} shorthands. r=emilio
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
|
||
Comment 11•5 years ago
|
||
Docs complete; Rachel Andrew wrote the docs a while ago and updated the compat data:
https://developer.mozilla.org/en-US/docs/Web/CSS/border-block-color#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/border-block-width#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/border-block-style#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/border-inline-color#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/border-inline-width#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/border-inline-style#Browser_compatibility
I added a note to the Fx 66 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/66#CSS
Description
•