The 'Flexible Space' item disappears from the customization pallette after adding it to the right side of the bookmark toolbar
Categories
(Firefox :: Toolbars and Customization, defect, P3)
Tracking
()
People
(Reporter: cbaica, Assigned: Gijs)
References
Details
Attachments
(2 files)
[Affected versions]:
- Fx 64.0 RC
- Fx 65.0b9
- Fx 66.0a1
[Affected platforms]:
- macOS 10.11
- Ubuntu 16.04 x32
- Windows 10 x64
[Steps to reproduce]:
- Launch Firefox.
- Enable the bookmark toolbar.
- Open the Hamburger menu and click on the 'Customize'.
- Drag the 'Flexible Space' on the right side of the bookmark toolbar.
[Expected result]:
- The 'flexible space' item is available to be added in other places after it is dropped on the bookmark toolbar.
[Actual result]:
- The 'flexible space' item is removed from the customization pallette.
[Regression range]:
Will get back with a regression range ASAP.
[Additional notes]:
If the user re-enters the Customization mode, the flexible space item will be available again.
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
•
|
||
This does not look like a regression. I have tracked the issue back to the following push log:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a418121d46250f91728b86d9eea331029c264c30&tochange=09a4282d1172ac255038e7ccacfd772140b219e2
That is when the Flexible Space item was added to the Customization mode: 1366813.
Updated•5 years ago
|
Comment 2•5 years ago
|
||
(The good news is that the flexible space comes back if Customize Mode is closed and re-opened)
Assignee | ||
Comment 3•5 years ago
|
||
Odd. Question is why we don't hit https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/browser/components/customizableui/CustomizeMode.jsm#1954-1957 in this case.
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to :Gijs (he/him) from comment #3)
Odd. Question is why we don't hit https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/browser/components/customizableui/CustomizeMode.jsm#1954-1957 in this case.
... oh, I guess in the case where we drag directly to an area we bail out in
Assignee | ||
Comment 6•4 years ago
|
||
Before this patch, we change aDraggedItemId somewhat late in the _applyDrop method -
significantly, we do this after the aTargetNode == areaCustomizationTarget check. So
we end up bailing out before adjusting aDraggedItemId, and we add the specific dummy
item from the palette into the toolbar, rather than adding a new spring to the
toolbar, and leaving the existing palette item alone.
Simply moving this adjustment to aDraggedItemId earlier into the method is sufficient
to fix the issue at hand.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4d96076060c7 ensure we don't end up without a flexible space if moving items directly to toolbars, r=dao
Comment 8•4 years ago
|
||
bugherder |
Comment 9•4 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Comment 10•4 years ago
|
||
Tested using Fx75.0b5 on windows 10, Ubuntu 18.04 and macOS 10.13. The flexible space no longer disappears after being added to the bookmark toolbar.
Description
•