Closed Bug 1515671 Opened 5 years ago Closed 5 years ago

[Ubuntu] Cancel/Remove Bookmark buttons are barely visible on hover state when in dark theme

Categories

(Firefox :: Theme, defect)

All
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 66
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- verified
firefox66 --- verified

People

(Reporter: asoncutean, Assigned: dao)

References

Details

(Keywords: regression, Whiteboard: fixed by bug 1515902)

Attachments

(1 file)

Attached image Screenshot issue.png
[Affected versions]: 
- 65.0b5 (20181217180946)
- 66.0a1 (20181220105637)

[Affected platforms]:
- Ubuntu 16.04 x64
- Ubuntu 18.04 x64

[Steps to reproduce]:
1. Set the theme to dark (Menu-Customize)
2. Bookmark any website via “Star” icon inside the URL bar
3. Hover over the “Cancel” button

[Expected result]:
- The button has no visibility issue. 

[Actual result]:
- The button is barely discernible. 

[Regression range]: 
- Last good revision: 4f04e189f2bbce09691a4877e45e3bf025402e4d
  First bad revision: 948718214f0b2ec4c9d8b6fca73fbca50c211239
  Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4f04e189f2bbce09691a4877e45e3bf025402e4d&tochange=948718214f0b2ec4c9d8b6fca73fbca50c211239

[Additional Notes]:
- “Remove bookmark” from “Edit This Bookmark” panel shows the same problem.
- I’ve noticed a similar visual issue inside the “Site information” panel - Content Blocking area, for Trackers and Cookies options, but only if the left click is kept pressed on the selected option.
Depends on: 1515902
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: fixed by bug 1515902
Target Milestone: --- → Firefox 66
Flags: qe-verify+
I have reproduced this bug with Nightly 66.0a1 (2018-12-20) on ManjaroLinux 18.0.1, 64 Bit!

This bug's fix is verified with the latest Nightly!

But 2nd issue from [Additional Notes] is not fixed yet.

Build ID   : 20181223215209
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0
QA Whiteboard: [bugday-20181226]
Status: RESOLVED → VERIFIED
Assignee: nobody → dao+bmo
This issue is also verified as fixed on the latest Beta 65.0b7 (20181227144402) on Ubuntu platforms (18.04 x64 and 16.04 x32). For the other problem, mentioned on Additional notes, I’ve filled another bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1516634) since it is related to the Fx 65 Cookie restriction feature and the regression range is different from the current issue.
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: