Closed Bug 1514775 (phab-switch) Opened 5 years ago Closed 5 years ago

[meta] Use Phabricator for all mozilla-central reviews

Categories

(Conduit :: General, enhancement, P1)

Product:
Conduit
Component:
General
Version:
Production
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

References

Details

(Keywords: conduit-story, conduit-triaged, meta)

User Story

When we are ready to resolve this bug, we should first disable the review flag for the following products:

Core
Firefox
Firefox Build System
NSPR
NSS
Toolkit
This is a tracker bug for work that must be completed before we require that all code reviews for mozilla-central patches be performed in Phabricator.
Depends on: 1503903
User Story: (updated)
Please fix either bug 1426557 or bug 1495394 before forcing me to install Phabricator dependencies.
Depends on: 1426557, 1495394
Hi, thanks for the comment, but please don't modify the blockers directly.

The current plan is to make moz-phab (our officially supported, commit-stack-friendly command-line tool) no longer require Arcanist.  After that it will be integrated into mach in some way.  However, that work may not be completed before we transition all mozilla-central reviews to Phabricator.  I realize installing Arcanist can be annoying, but more than 80% of the commits currently going into mozilla-central are being reviewed in Phabricator, so it appears that installing Arcanist is not a major blocker to adoption.
No longer depends on: 1426557, 1495394
Depends on: 1515369
Keywords: conduit-story, conduit-triaged
Depends on: 1521554
Depends on: 1409964
Depends on: 1525029
Depends on: 1446555
Depends on: 1498171
Keywords: meta
Priority: -- → P1
Summary: [Tracker] Use Phabricator for all mozilla-central reviews → [meta] Use Phabricator for all mozilla-central reviews
No longer depends on: 1498171
No longer depends on: 1446555

Please don't add new blockers to this bug; needinfo myself or kmoir on a bug to nominate it for blocking.

Why not including "GeckoView" and "Firefox for Android"? These products use m-c.

Depends on: 1495394
Depends on: 1525284

(In reply to Makoto Kato [:m_kato] from comment #4)

Why not including "GeckoView" and "Firefox for Android"? These products use m-c.

From the announcement:

The list includes the Core, Firefox, Firefox Build System, NSS, Geckoview
and Toolkit products. It will also include some components of the Release
Engineering and Testing products. It is entirely possible that we will miss
some products/components, but users should not treat such omissions as
invitations to continue to use Bugzilla for mozilla-central reviews.

Alias: phab-switch
Depends on: 1526946
No longer depends on: 1495394
Depends on: 1526952
No longer depends on: 1409964

Closing. Thanks to everyone for all your work on this!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.