Enable Visual Viewport API by default on Android
Categories
(Core :: Panning and Zooming, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: JanH, Assigned: botond)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
I.e. flip "dom.visualviewport.enabled" to true by default. As far as I can see, this won't be required for internal session store/history usage, though, because a) I intend to use some additional internal events that don't require listening on the VisualViewport object b) there already are some internal helper methods for getting the visual viewport offset without going through the VisualViewport object
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
•
|
||
Kats, what do you think about making dom.visualviewport.enabled conditional on apz.allow_zooming (and, until bug 1459260 is resolved, dom.meta-viewport.enabled)?
The motivation for this is that correct updating of the visual viewport properties and dispatching of events and such currently relies on MobileViewportManager. We'd have to add new codepaths if we wanted e.g. visual viewport resize events to be fired without apz.allow_zooming=true.
Seeing as the motivating uses of the Visual Viewport API involve zooming, and even if we added such non-zooming codepaths now, they'd go way when we implemented desktop zooming, it seems to me that doing so would be rather pointless.
Thoughts?
|
|
Assignee | |
Comment 3•5 years ago
|
||
Intent to ship email: https://groups.google.com/forum/#!topic/mozilla.dev.platform/Mkw_Toh9Siw
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90bd618a9449 Enable the Visual Viewport API on Android. r=kats
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 7•5 years ago
|
||
Updating bug title to reflect that the enablement by default happened on Android only for now.
Enablement by default on desktop is tracked in bug 1551302 and depends on desktop zooming.
|
||
Comment 8•5 years ago
|
||
Documentation updates:
- Submitted [BCD PR 4347)(https://github.com/mdn/browser-compat-data/pull/4347) noting that
VisualViewportis now enabled by default on Android Firefox. - Listed on Firefox 68 for developers
Description
•