Erica Wright [:ewright] Assignee
	Description • 5 years ago

I've attached a screenshot of the new proposed spotlight visuals. 

the dotted outline is photon blue-60.
the background is photon blue-40 at 1% alpha.
it fades after 2 seconds with a 500ms animation.

	Erica Wright [:ewright] Assignee
	Comment 1 • 5 years ago

Change the coloring of the spotlight, and add a fadeout

	Pulsebot
	Comment 2 • 5 years ago

Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59a0f0a43a12
Update preferences spotlight color. r=jaws

	Cristina Coroiu [:ccoroiu]
	Comment 3 • 5 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/59a0f0a43a12

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 5 years ago

Is this something we wanted to nominate for Beta uplift?

	Erica Wright [:ewright] Assignee
	Comment 5 • 5 years ago

Comment on attachment 9029626 [details]
Bug 1512187 - Update preferences spotlight color.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: The previous aqua highlight clashes with the new privacy UI landing in 65. This new highlight looks good with the new UI and the old UI.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): straightforward css visual change

String changes made/needed: none

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 5 years ago

Comment on attachment 9029626 [details]
Bug 1512187 - Update preferences spotlight color.

[Triage Comment]
Visual tweak for the preferences spotlight. Approved for 65.0b6.

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 5 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/2fe74b55dfcc