Closed
Bug 1510929
Opened 5 years ago
Closed 5 years ago
Remove "script_timeout" parameter from Execute (Async) Script
Categories
(Remote Protocol :: Marionette, enhancement, P1)
Remote Protocol
Marionette
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: whimboo, Assigned: ato)
References
Details
Attachments
(2 files, 2 obsolete files)
As discussed on bug 1128997 comment 12 we would like to see the `script_timeout` argument to be removed from both of those commands. There is no need to have a third way to set the timeout beside capabilities in `New Session`, and the `Set Timeouts` command.
Assignee | ||
Comment 1•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7f0ea41b6776ad8c2c5460b999c3900712d9374
Assignee | ||
Comment 2•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5f9d40dddc466614f0c5066fd6519f0771531ed
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
This removes the script_timeouts keyword argument from Marionette#execute_script and #execute_async_script as it is not compatible with the semantic meaning associated with null in WebDriver. The script timeout duration for the session can instead be set using Marionette#timeouts#script. Depends on D13993
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/919fea1e5337 puppeteer: remove use of script_timeout; r=whimboo https://hg.mozilla.org/integration/autoland/rev/87416015abce marionette: remove script_timeout kwarg from client; r=whimboo
Comment 6•5 years ago
|
||
Backed out for awsy failures Backout link: https://hg.mozilla.org/integration/autoland/rev/69899db5ee27f613e28a68af03f4e97d8693841e Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&selectedJob=218222437&revision=87416015abce1d9108dca33f84b1a4a98f3d9422 Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=218226196&repo=autoland&lineNumber=1066
Flags: needinfo?(ato)
Comment 7•5 years ago
|
||
Would it make sense to just move whatever hoop jumping you added in patch 1 into `execute_async_script` rather than pushing it out to all callers?
Assignee | ||
Comment 8•5 years ago
|
||
(In reply to Eric Rahm [:erahm] (PTO until Jan 3) from comment #7) > Would it make sense to just move whatever hoop jumping you added in patch 1 > into `execute_async_script` rather than pushing it out to all callers? Yes, we could do that instead.
Assignee | ||
Comment 9•5 years ago
|
||
By stopping to use the scriptTimeout parameter with the WebDriver:ExecuteScript and WebDriver:ExecuteAsyncScript commands in the Marionette Python client, we can remove it from the server.
Assignee | ||
Comment 10•5 years ago
|
||
Depends on D15583
Updated•5 years ago
|
Attachment #9030011 -
Attachment is obsolete: true
Updated•5 years ago
|
Attachment #9030010 -
Attachment is obsolete: true
Assignee | ||
Comment 11•5 years ago
|
||
Re-submitted patches that preserves the client script_timeout kwarg, but removes the scriptTimeout parameter to Marionette.
Flags: needinfo?(ato)
Comment 12•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afe5d9b5a7f4 marionette: stop using scriptTimeout parameter; r=whimboo https://hg.mozilla.org/integration/autoland/rev/f3c28d11924b marionette: remove scriptTimeout parameter; r=whimboo
Comment 13•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/afe5d9b5a7f4 https://hg.mozilla.org/mozilla-central/rev/f3c28d11924b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•