Closed
Bug 1508824
Opened 6 years ago
Closed 6 years ago
SharedWorker.onconnect event should be a MessageEvent with an empty string as data
Categories
(Core :: DOM: Workers, enhancement, P2)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
1.23 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
Currently data is a null, but the spec says: "If is shared is true, then queue a task, using the DOM manipulation task source, to fire an event named connect at worker global scope, using MessageEvent, with the data attribute initialized to the empty string, the ports attribute initialized to a new frozen array containing inside port, and the source attribute initialized to inside port."
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9026528 -
Flags: review?(bugmail)
|
||
Updated•6 years ago
|
Priority: -- → P2
|
||
Updated•6 years ago
|
Attachment #9026528 -
Flags: review?(bugmail) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/434b3eacae09 SharedWorker.onconnect event should be a MessageEvent with an empty string as data, r=asuth
|
||
Updated•6 years ago
|
Keywords: dev-doc-needed
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/434b3eacae09
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
|
||
Comment 4•5 years ago
|
||
Note to MDN writers: I have added a note to the Fx 65 rel notes to cover this change: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs However we have not yet documented SharedWorker.onconnect, so this needs doing, along with the associated compat data, etc.
|
|
||
Comment 5•5 years ago
|
||
I have documented this by
adding a note here:
https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope/onconnect#Examples
adding a note to the Fx65 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#Web_workers
I didn't think a specific entry in the browser compat data was appropriate here — it is a pretty minor addition, and would be hard to communicate in the compat data without being confusing.
Let me know if this sounds OK.
Flags: needinfo?(amarchesini)
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•