Tooru Fujisawa [:arai] Assignee
	Description • 6 years ago

Separated from bug 1506655.

window.open's feature parameters which controls UI parts (tabbar, menubar, toolbar, personalbar) is supported only in Firefox and IE [1],
and it causes confusing behavior around UI to control visibility of those parts (bug 1506655), and also causes trouble around sessionrestore (the same bug, bug 1506655)

Given the feature is not supported on other modern browsers, can we drop it?

The other browser's behavior is following:
  * Edge
    * opens a window which has only location bar
    * hitting Ctrl+T does nothing
  * Chrome
    * opens a window which has only location bar
    * hitting Cmd+T opens new tab in other window
  * Safari
    * opens a window which behaves samely as normal window
      (has all UI parts)
    * hitting Cmd+T opens new tab in that window

more behavior related to session store is described in bug 1506655 comment #7.

Then, I think Chrome's behavior is same as Firefox when the feature is only "locationbar".
So I think dropping support for them and open a window only with location bar regardless of those features is the simplest solution.

[1] https://developer.mozilla.org/ja/docs/Web/API/window.open#Window_features

	Tooru Fujisawa [:arai] Assignee
	Comment 1 • 6 years ago

bz, can I have your opinion again?
I think this at least won't cause much web-compat issue.

	Boris Zbarsky [:bzbarsky]
	Comment 2 • 6 years ago

I'm not quite following the proposal.  What is the actual proposed behavior when the page asks for, say, "locationbar,toolbar,menubar"?  What is the proposed behavior when the page asks for "locationbar,toolbar,menubar,tabbar,personalbar"?  What about other feature combinations?

	Tooru Fujisawa [:arai] Assignee
	Comment 3 • 6 years ago

okay, let me check more about the combinations, and write down the proposal.
hopefully in this weekend

	Dão Gottwald [:dao]
	Comment 4 • 6 years ago

(In reply to Tooru Fujisawa [:arai] from comment #0)
> Separated from bug 1506655.
> 
> window.open's feature parameters which controls UI parts (tabbar, menubar,
> toolbar, personalbar) is supported only in Firefox and IE [1],

Do we actually support all of these? I thought we only supported the toolbar feature. More precisely, toolbar=no, as toolbar=yes would be the default...

> Given the feature is not supported on other modern browsers, can we drop it?
> 
> The other browser's behavior is following:
>   * Edge
>     * opens a window which has only location bar
>     * hitting Ctrl+T does nothing
>   * Chrome
>     * opens a window which has only location bar
>     * hitting Cmd+T opens new tab in other window

I'm not sure I'm following. It sounds like Chrome presents popups just like we do, and Edge too except for refusing to open a tab.

Could it be that https://developer.mozilla.org/en-US/docs/Web/API/Window/open is just outdated? It lists Netscape 6, Netscape 7, and Mozilla 1.0 which I don't think any web developer cares about today...

	Tooru Fujisawa [:arai] Assignee
	Comment 5 • 6 years ago

(In reply to Dão Gottwald [::dao] from comment #4)
> (In reply to Tooru Fujisawa [:arai] from comment #0)
> > Separated from bug 1506655.
> > 
> > window.open's feature parameters which controls UI parts (tabbar, menubar,
> > toolbar, personalbar) is supported only in Firefox and IE [1],
> 
> Do we actually support all of these? I thought we only supported the toolbar
> feature. More precisely, toolbar=no, as toolbar=yes would be the default...

yes, window.open can control the visibility of tabbar, toolbar (backward button etc), bookmark toolbar,
in the opened window, and it's saved and restored across restart.

	Tooru Fujisawa [:arai] Assignee
	Comment 7 • 6 years ago

so far, here's the behavior of Chrome, Safari, and Edge.
based on observation, I might overlook some other conditions.

features parameter can control what to open (popup, window, tab), but the visibility of UI parts are not controllable (visible UI parts are fixed for each case)

I'll prepare proposal for Firefox.

	Tooru Fujisawa [:arai] Assignee
	Comment 8 • 6 years ago

Comment on attachment 9027089 [details]
Chrome, Safari, and Edge's behavior

After some more tests, it turns out the behavior is a bit more complicated.
here's the latest document:
  https://arai-a.github.io/window-open-features/

and testcase:
  https://arai-a.github.io/window-open-features/test.html

	Pulsebot
	Comment 22 • 4 years ago

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/6fe5ce050c0d
Restrict the controllability of UI parts visibility with features parameter of window.open. r=smaug

	Pulsebot
	Comment 24 • 4 years ago

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/bf0e49a9ceff
Restrict the controllability of UI parts visibility with features parameter of window.open. r=smaug