Closed
Bug 1506878
Opened 6 years ago
Closed 6 years ago
"Unmute tabs" and "Mute tabs" should use the same access key
Categories
(Firefox :: Tabbed Browser, defect, P3)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox63 | --- | unaffected |
firefox64 | --- | wontfix |
firefox65 | --- | verified |
People
(Reporter: cfogel, Assigned: jaws)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
[Note]: - In reply to https://bugzilla.mozilla.org/show_bug.cgi?id=1497505#c5 [Affected versions]: - 64.0b8, 65.0a1 (2018-11-12) [Affected platforms]: - win10, Ubuntu16.04, macOS 10.14 [Steps to reproduce]: 1. Launch Firefox; 2. Right click on the tab_name; 3. Click on the Mute option; 4. Repeat steps 2+3 (Unmute Option); [Expected result]: - Access keys should be one and the same for both mute / unmute option; [Actual result]: - current state: Unmute ta[b]s / M[u]te tabs. [Regression range]: - introduced with 1497505
Reporter | ||
Comment 1•6 years ago
|
||
*Ignore the regression note
Assignee | ||
Updated•6 years ago
|
Blocks: tabs-multiselect
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Updated•6 years ago
|
Attachment #9025777 -
Attachment description: Bug 1506878 - Use the same accesskey for Unmute Tabs and Mute Tabs as we do for Unmute Tab and Mute Tab. r?dao → Bug 1506878 - Use the same accesskey for Unmute Tabs and Mute Tabs as we do for Unmute Tab and Mute Tab. r?flod
Updated•6 years ago
|
Attachment #9025777 -
Attachment description: Bug 1506878 - Use the same accesskey for Unmute Tabs and Mute Tabs as we do for Unmute Tab and Mute Tab. r?flod → Bug 1506878 - Use the same accesskey for Unmute Tabs and Mute Tabs as we do for Unmute Tab and Mute Tab. r?dao
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f16a83697cc Use the same accesskey for Unmute Tabs and Mute Tabs as we do for Unmute Tab and Mute Tab. r=dao
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f16a83697cc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Reporter | ||
Comment 5•6 years ago
|
||
Verified with 65.0a1 (2018-11-18) on Win10, macOS10.13, Ubuntu16.04.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 7•6 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #6) > Is this something you wanted to uplift to Beta? As it changes user-facing strings I didn't think it was something that *could* be uplifted. Though if we can uplift it then I would like to, yes.
Flags: needinfo?(jaws) → needinfo?(ryanvm)
Comment 8•6 years ago
|
||
Whoops, I'll admit I didn't actually look at the patch before asking that question :). You're right, uplifting is a no-go here.
Flags: needinfo?(ryanvm)
You need to log in
before you can comment on or make changes to this bug.
Description
•