Camelia Badau [:cbadau], Desktop QA Reporter
	Description • 6 years ago

[Affected versions]:
- Firefox 64 Beta 9
- Nightly 65.0a1 (2018-11-12)
- Firefox 63.0.1 

[Affected platforms]:
- Windows 7 x64
- Windows 10 x64
- Ubuntu 18.04 x64
- macOS 10.13

[Steps to reproduce]:
1. Launch Firefox.
2. Log with the same FF account on two devices/two Firefox instances (Device 1 and Device 2).
3. Make sure that identity.fxaccounts.commands.enabled pref is true.
4. Send tab from Device 1 to Device 2.
5. Open Browser Console on Device 2 and verify the “Receiving a tab from  <device name> using FxA commands .” message is displayed.

[Expected result]:
- The “Receiving a tab from <device name> using FxA commands .” message is displayed in console.

[Actual result]:
- The “Receiving a tab from <device name> using FxA commands .” message is NOT displayed in console.
Error console displayed: "Content Security Policy: Ignoring “'unsafe-inline'” within script-src or style-src: nonce-source or hash-source specified"

[Regression range]:
- I will search for a regression asap.

	Edouard Oger [:eoger]
	Comment 1 • 6 years ago

Which versions of Firefox are sending and receiving?

	Camelia Badau [:cbadau], Desktop QA Reporter
	Comment 2 • 6 years ago

I've tried on:
- two Firefox 64 Beta 9 instances -> sending from Firefox 64 Beta 9 (Device 1) and receiving on Firefox 64 Beta 9 (Device 2)
- two latest Nightly 65.0a1 instances -> sending from latest Nightly 65.0a1 (Device 1) and receiving on latest Nightly 65.0a1 (Device 2)
- two Firefox 63.0.1 Firefox instances (after I set the identity.fxaccounts.commands.enabled pref to true)
- one Firefox 64 Beta 9 instance (receiving) and iOS beta 14 (sending)

	Edouard Oger [:eoger]
	Comment 3 • 6 years ago

I think Firefox 63 should be ruled out as FxA commands is scheduled officially for 64 and we might have patched it in the nightly period.
Are you experiencing the problems between 64+ instances?

	Ryan Kelly [:rfkelly]
	Comment 4 • 6 years ago

I recall changing a console.log() to a log.info() as part of a cleanup patch in Bug 1487601.  :eoger, this was while you were on PTO, perhaps Mark and I accidentally busted your test plan by doing that?

	Edouard Oger [:eoger]
	Comment 5 • 6 years ago

I think that's fine, just need to turn on the prefs as described in Bug 1506139.

	Camelia Badau [:cbadau], Desktop QA Reporter
	Comment 6 • 6 years ago

(In reply to Edouard Oger [:eoger] from comment #3)
> I think Firefox 63 should be ruled out as FxA commands is scheduled
> officially for 64 and we might have patched it in the nightly period.
> Are you experiencing the problems between 64+ instances?

Yes, we reproduced the issue between 64+ instances (Firefox 64 Beta 9, latest Nightly 65.0a1).

	Edouard Oger [:eoger]
	Comment 7 • 6 years ago

Did you set the following prefs?
 - services.sync.log.appender.file.logOnSuccess=true
 - identity.fxaccounts.loglevel=Info

If yes and you can still reproduce the problem, would you mind making a more complete bug report following this guide? [0]
Thanks!

[0] https://docs.google.com/document/d/1ijwUo0VmK8xVIyMd2eTwtDClreve1IlP4TixSBpyDPI

	Camelia Badau [:cbadau], Desktop QA Reporter
	Comment 8 • 6 years ago

I've tested with these prefs: services.sync.log.appender.file.logOnSuccess=true and identity.fxaccounts.loglevel=Info and I still reproduced the issue. Please see in the "abc.png" attachment the error displayed in Browser Console on receiving device/instance. I've tested using Firefox 64 Beta 11 build (20181119162153).

	Camelia Badau [:cbadau], Desktop QA Reporter
	Comment 9 • 6 years ago

-Complete bug report- 


Applications and platforms:
- Windows 7 x64 - Firefox 64 Beta 11
- Windows 10 x64 - Firefox 64 Beta 11
- Ubuntu  18.04 x64 - Firefox 64 Beta 11
- mac OS 10.13 - Firefox 64 Beta 11

Reproducible:
- see STR in Description

Cloud configuration: 
- I am using the FxA stable server (https://stable.dev.lcip.org)

Clients records and FxA device list:

Clients “Records (object)”: 

0: Object
os: "iOS"
fxaDeviceId: "d90c85a20f04f5bcd307b2e1df4ca70d"
version: "14.0"
commands: Array[0]
appPackage: "org.mozilla.ios.FirefoxBeta"
name: "Firefox Beta on Catalin’s iPhone"
type: "mobile"
protocols: Array[1]
id: "V6PKCXnRwKvE"
formfactor: "phone"
device: "iPhone"
application: "Firefox Beta"

1: Object
id: "Etr9dKLq5HnE"
fxaDeviceId: "801ef12424ec37f0f25eac415e8219e5"
name: "svuser’s Firefox on SL123-207"
type: "desktop"
version: "64.0"
protocols: Array[1]
os: "Darwin"
appPackage: "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"
application: "Firefox"

2: Object
id:"5hJR7vHydc8i"
fxaDeviceId: "9cf9f6947239abf691253ef2c63c15ff"
name: "A"
type: "desktop"
version: "64.0"
protocols: Array[1]
os: "WINNT"
appPackage: "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"
application: "Firefox"


FxA device list:

0: Object
id: "801ef12424ec37f0f25eac415e8219e5"
isCurrentDevice: false
location: Object
name: "svuser’s Firefox on SL123-207"
type: "desktop"
pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABb9nG3z4ol8h6yPTZfZs6NSSYffA9Pb7EibvP9TjcCW2Rist-lqGASmX2hh8Q2BY2dq6_KpjbkY9YhpHY4bulSQBfCBu90bWXD5theyLWJGLIgCcpKkg6yJCausVVcmMwwsYhu"
pushPublicKey: "BBLeC7ahPkinDSb3q9v1dPsBL9IEI4K7PgDg37AaLyYCeP2PrphCHsTVJqxD4qLnCKFnG7wMi5QhXl0JH8TH09o"
pushAuthKey: "B4Ha-ZPYbJDhYISVKT4Xxg"
pushEndpointExpired: false
availableCommands: Object
lastAccessTime: 1542878102690
lastAccessTimeFormatted: "an hour ago"

1: Object
id: "9cf9f6947239abf691253ef2c63c15ff"
isCurrentDevice: true
location: Object
name: "A"
type: "desktop"
pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABb9n97zYbcifWgOIQlAWiFMcV9vTsrQjZU1bawNFTu59AOt9EE6y-s9mSypKinbvjqJKpJww6Ju3ni9UDP0HxiFAZoY-a6A96IbG_IMiIf5j5K6Rn2w0DLZBaBf7jJsjhj59wX"
pushPublicKey: "BPQqOr0ELXPCxkOqii9oTkTLukfVbWmLEqcQLGHIOZ9KygsIXSPnqGl3uGHfw9SshWxfngTP7Rcd06XsIAJGduU"
pushAuthKey: "QLWAQQSufUtLBs22vJuOsA"
pushEndpointExpired: false
availableCommands: Object
lastAccessTime: 1542881147272
lastAccessTimeFormatted: "13 minutes ago"

2: Object
id: "d90c85a20f04f5bcd307b2e1df4ca70d"
isCurrentDevice: false
location: Object
name: "Firefox Beta on Catalin’s iPhone"
type: "mobile"
pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABb9n32yywSp3TIL-hjQNuQS4YZhseuqvmq-dNoxG68hv9gQeElbBaXlxvARkK9B1oTyS7E866Yt0XBaVtfMFrg7xkhGeFoCA4ab3s_Wnu2Klo0mCWcXn5zc6b7FjbvayfjOxbF"
pushPublicKey: "BD1wBCmoFyGfLTcSReWGigkJI3V3CnH2gOfYNYrr35lZYLZ9aIGI2VSOGmXka7UsJSKeJ_zUrH0sPfjXTlt2j2I"
pushAuthKey: "s3iL6_cPUnAa1dBPVgrJaA"
pushEndpointExpired: false
availableCommands: Object
lastAccessTime: 1542881290353
lastAccessTimeFormatted: "11 minutes ago"


Logs:
- see the Firefox Desktop logs from about:sync-log in attachment "logs.zip"

	Camelia Badau [:cbadau], Desktop QA Reporter
	Comment 10 • 6 years ago

I forgot to mention on "Applications and platforms" section the following: 
- iOS 11.4.1 - Firefox for iOS Beta 14 (build: 12646)
- Android 8.0 - Firefox for Android 64.0b11

	Edouard Oger [:eoger]
	Comment 11 • 6 years ago

From this report I see 3 devices connected on the 6 announced, the STR needs to be more specific (who's sending to who?), when are the logs created? Would it be possible to make the report more minimal?

	Camelia Badau [:cbadau], Desktop QA Reporter
	Comment 12 • 6 years ago

I've tested today using Firefox 64 Beta 12.

Note: It doesn't matter who sending to who because the issue is reproducible on all platforms/applications: from Desktop to Desktop (2 Firefox instances), from iOS to Desktop, from Android to Desktop. 


Scenario:
1. Launch Firefox 64 Beta 12 on desktop (Windows 7 x64) and log in with FF account. 
2. Launch Firefox Beta 14 (build:12646) on iPhone 8 and log in with the same FF account. 
3. On desktop (Windows 7) open about:config and set services.sync.log.appender.file.logOnSuccess=true and identity.fxaccounts.loglevel=Info. 
4. From iPhone 8 send a tab to desktop (Windows 7). 
5. Go to desktop (Windows 7) and see if the tab from iPhone is received. 
6. On desktop (Windows 7) open Browser Console and see if you have any message/error message here. 
7. On desktop (Windows 7) open about:sync-log and see the logs. 

Actual results: 
- step 5 - the tab is correctly received on desktop (Windows 7)
- at step 6, I don't have any message or error displayed in Browser Console on desktop (Windows 7). 
- at step 7, I have the following logs received immediately after the tab from iPhone is received: see attachment "iPhoneDesktopLogs.zip". 

I installed  the About Sync extension and I have the following details: 
Records (objects)
0: Object
id: "Qo4sQC5qI8xX"
fxaDeviceId: "29c39a778322962e324567dd15626fb3"
name: "camelia.badau’s Firefox on P5071"
type: "desktop"
version: "64.0"
protocols: Array[1]
os: "WINNT"
appPackage: "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"
application: "Firefox"

1: Object
formfactor: "phone"
application: "Firefox Beta"
device: "iPhone"
id: "pKhhtHhVxs2b"
name: "Firefox Beta on Catalin’s iPhone"
os: "iOS"
commands: Array[0]
version: "14.0"
type: "mobile"
protocols: Array[1]
appPackage: "org.mozilla.ios.FirefoxBeta"
fxaDeviceId: "0a2d5ba224c738bb75135c5b9102e9ff"

FxA device list:
0: Object
id: "0a2d5ba224c738bb75135c5b9102e9ff"
isCurrentDevice: false
location: Object
name: "Firefox Beta on Catalin’s iPhone"
type: "mobile"
pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABb-BE7tghd3f5lIlHQO0vg5D7mcUyIgizNLGXfPy1BSXqCpcBCm0-143yaldAhLA3B2iwDdc8iaJ2WJ_SHjZ3f5Pe5PS2lcDXYptgSfe8ZaZyNaU5dE-B1V6mfTOZU9XhFG3pU"
pushPublicKey: "BEOVuNM3yVAWm-ApdwkjpVtiKXOHmk1z-Y-3c3F_MhvqM8fN6Yo9dBiFtWQdLQLYgZNfpKHhLzazRWuZOAmiLhc"
pushAuthKey: "ajV2S12au5B_-dQzJaG6iQ"
pushEndpointExpired: false
availableCommands: Object
lastAccessTime: 1542983997833
lastAccessTimeFormatted: "44 minutes ago"

1: Object
id: "29c39a778322962e324567dd15626fb3"
isCurrentDevice: true
location: Object
name: "camelia.badau’s Firefox on P5071"
type: "desktop"
pushCallback: "https://updates.push.services.mozilla.com/wpush/v1/gAAAAABb-BefalMQdldR0s-jBxgeuk3b65gtAYwyNk4vuSa7QB8AFTbR8M8DvL4440RLrbJFVn3jLlBdmxeMbkFZa-aAdfhA5oFxATMrmV0qUhh0gELHNr8MiFiorkSQAUB8jPIIWRrk"
pushPublicKey: "BGVXa9TwJ1r2EFxCbGr_hQjpG2fjmpAPluO2Q1OpdHRSfLYITxOitPNVX9LeFcv4qCEYnUR_Wg_tjIRvpjfr45c"
pushAuthKey: "zkA6btAlxdxLa7dMFw6bvA"
pushEndpointExpired: false
availableCommands: Object
lastAccessTime: 1542985839790
lastAccessTimeFormatted: "13 minutes ago"

	Edouard Oger [:eoger]
	Comment 13 • 6 years ago

I'm seeing
> 1542986486270	FirefoxAccounts	INFO	Tab received with FxA commands: Twitter. It’s what’s happening / Twitter from Firefox Beta on Catalin’s iPhone.
in the Desktop logs you sent, looks like this works as expected?

	Ryan Kelly [:rfkelly]
	Comment 14 • 6 years ago

It sounds like the issue here may be just that the info is logged in a different place than expected, can you confirm?

	Camelia Badau [:cbadau], Desktop QA Reporter
	Comment 15 • 6 years ago

(In reply to Ryan Kelly [:rfkelly] from comment #14)
> It sounds like the issue here may be just that the info is logged in a
> different place than expected, can you confirm?

Yes, the info is logged in Firefox Desktop logs (about:sync-log), but NOT in Browser Console.

The tab from iPhone is correctly received on desktop, the "1543321551598 FirefoxAccounts INFO Tab received with FxA commands: Wikipedia from Firefox Beta on Catalin’s iPhone." message appears in Firefox Desktop logs (about:sync-log), but there is NO message about the tab receiving in Browser Console/Toolbox.

	Mark Hammond [:markh] [:mhammond]
	Comment 16 • 5 years ago

This sounds like it is working fine and just an issue with the test plan