Closed
Bug 1506761
Opened 6 years ago
Closed 5 years ago
Vary the nursery free threshold based on nursery size
Categories
(Core :: JavaScript: GC, enhancement, P1)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: pbone, Assigned: pbone)
References
Details
Attachments
(2 files)
It might be a good idea to vary this tunable. https://searchfox.org/mozilla-central/source/js/src/gc/Scheduling.h#462 depending on nursery size. Or maybe interpret it differently.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → pbone
Status: NEW → ASSIGNED
status-firefox67:
--- → fix-optional
Priority: P3 → P1
Target Milestone: --- → mozilla67
|
|
Assignee | |
Comment 1•5 years ago
|
||
This makes more sense as a follow up for Bug 1433007 (or at the same time).
|
|
Assignee | |
Comment 2•5 years ago
|
||
We collect the nursery in idle time if there is less than 256KB of space
remaining. However when the nursery is small this doesn't make sense, so
add a percentage-based threshold to be used when the nursery is small.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D20247
|
|
Assignee | |
Comment 4•5 years ago
|
||
This is ready to land but I want to let telemetry settle after my last change.
Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df61ae31e2a8 Add a fraction threshold for collecting the nursery r=sfink https://hg.mozilla.org/integration/autoland/rev/1a6bfb6eba8a Fix existing spelling error r=sfink
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/df61ae31e2a8
https://hg.mozilla.org/mozilla-central/rev/1a6bfb6eba8a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•