Closed Bug 1506621 Opened 5 years ago Closed 5 years ago

Builds broken due to archiver interface change

Categories

(Taskcluster :: Workers, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmoore, Assigned: pmoore)

References

Details

Attachments

(1 file)

A dependency used by generic-worker is https://github.com/mholt/archiver whose interface has changed in the last few days.

At some point we may wish to freeze dependencies, but for now, let's just update to use the new interface. Especially with dependencies such as archive extractors, it can be beneficial to have relatively recent versions, since they can contain security fixes not present in earlier versions.

Build failures look like this:

# github.com/taskcluster/generic-worker
./mounts.go:653:22: invalid method expression archiver.Zip.Open (needs pointer receiver: (*archiver.Zip).Open)
./mounts.go:653:22: archiver.Zip.Open undefined (type archiver.Zip has no method Open)
./mounts.go:655:24: invalid method expression archiver.TarGz.Open (needs pointer receiver: (*archiver.TarGz).Open)
./mounts.go:655:24: archiver.TarGz.Open undefined (type archiver.TarGz has no method Open)
./mounts.go:657:22: invalid method expression archiver.Rar.Open (needs pointer receiver: (*archiver.Rar).Open)
./mounts.go:657:22: archiver.Rar.Open undefined (type archiver.Rar has no method Open)
./mounts.go:659:25: invalid method expression archiver.TarBz2.Open (needs pointer receiver: (*archiver.TarBz2).Open)
./mounts.go:659:25: archiver.TarBz2.Open undefined (type archiver.TarBz2 has no method Open)
github.com/taskcluster/generic-worker/worker_types/transform-occ
Attached file GitHub Pull Request
Assignee: nobody → pmoore
Attachment #9024470 - Flags: review?(jhford)
Commits pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/374065f7ee94934c598526bbe493177ff11a6b83
Bug 1506621 - update code to use new (v3) github.com/mholt/archiver interface

https://github.com/taskcluster/generic-worker/commit/d08a3685a6bb45a294a88f79e314cbe31c6de492
Merge pull request #130 from taskcluster/bug1506621

Bug 1506621 - update code to use new (v3) github.com/mholt/archiver interface
Comment on attachment 9024470 [details] [review]
GitHub Pull Request

r+ from github
Attachment #9024470 - Flags: review?(jhford) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: Generic-Worker → Workers

Released in generic-worker 11.1.0.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: