Closed
Bug 1506621
Opened 5 years ago
Closed 5 years ago
Builds broken due to archiver interface change
Categories
(Taskcluster :: Workers, enhancement)
Taskcluster
Workers
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pmoore, Assigned: pmoore)
References
Details
Attachments
(1 file)
A dependency used by generic-worker is https://github.com/mholt/archiver whose interface has changed in the last few days. At some point we may wish to freeze dependencies, but for now, let's just update to use the new interface. Especially with dependencies such as archive extractors, it can be beneficial to have relatively recent versions, since they can contain security fixes not present in earlier versions. Build failures look like this: # github.com/taskcluster/generic-worker ./mounts.go:653:22: invalid method expression archiver.Zip.Open (needs pointer receiver: (*archiver.Zip).Open) ./mounts.go:653:22: archiver.Zip.Open undefined (type archiver.Zip has no method Open) ./mounts.go:655:24: invalid method expression archiver.TarGz.Open (needs pointer receiver: (*archiver.TarGz).Open) ./mounts.go:655:24: archiver.TarGz.Open undefined (type archiver.TarGz has no method Open) ./mounts.go:657:22: invalid method expression archiver.Rar.Open (needs pointer receiver: (*archiver.Rar).Open) ./mounts.go:657:22: archiver.Rar.Open undefined (type archiver.Rar has no method Open) ./mounts.go:659:25: invalid method expression archiver.TarBz2.Open (needs pointer receiver: (*archiver.TarBz2).Open) ./mounts.go:659:25: archiver.TarBz2.Open undefined (type archiver.TarBz2 has no method Open) github.com/taskcluster/generic-worker/worker_types/transform-occ
Assignee | ||
Comment 1•5 years ago
|
||
Assignee: nobody → pmoore
Attachment #9024470 -
Flags: review?(jhford)
Comment 2•5 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/generic-worker https://github.com/taskcluster/generic-worker/commit/374065f7ee94934c598526bbe493177ff11a6b83 Bug 1506621 - update code to use new (v3) github.com/mholt/archiver interface https://github.com/taskcluster/generic-worker/commit/d08a3685a6bb45a294a88f79e314cbe31c6de492 Merge pull request #130 from taskcluster/bug1506621 Bug 1506621 - update code to use new (v3) github.com/mholt/archiver interface
Assignee | ||
Comment 3•5 years ago
|
||
Comment on attachment 9024470 [details] [review] GitHub Pull Request r+ from github
Attachment #9024470 -
Flags: review?(jhford) → review+
Assignee | ||
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment 5•5 years ago
|
||
Commit pushed to master at https://github.com/taskcluster/generic-worker https://github.com/taskcluster/generic-worker/commit/8733f3ad5281706801d834c2cfd268a92b447bc8 Merge remote-tracking branch 'origin/bug1506621'
Updated•5 years ago
|
Component: Generic-Worker → Workers
Assignee | ||
Comment 6•5 years ago
|
||
Released in generic-worker 11.1.0.
You need to log in
before you can comment on or make changes to this bug.
Description
•