Closed Bug 1506139 Opened 6 years ago Closed 5 years ago

Logs are not diplayed in about:sync-log page after sending tabs from iOS to Desktop

Categories

(Firefox :: Sync, defect)

64 Branch
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox64 --- disabled
firefox65 --- unaffected

People

(Reporter: mboldan, Unassigned)

Details

[Affected versions]:
- Firefox 64.0b8

[Affected platforms]:
- Windows 10x64, Mac OS X 10.12.6, Ubuntu 18.04x64
- iPhone SE

[Steps to reproduce]:
1. Launch Firefox.
2. Log with the same FF account on a desktop and on an iOS device.
3. Make sure that identity.fxaccounts.commands.enabled pref is true.
4. Send a tab from iOS device to desktop.
5. Go to about:sync-log page.

[Expected result]:
- The log files are correctly displayed.

[Actual result]:
- Nothing is displayed.

[Regression range]:
- I will search for a regression asap.

[Additional notes]:
- This issue is not reproducible on Firefox 65.0a1(2018-11-09)
- Note that no logs are displayed also it tabs are sent from desktop to iOS device.
> This issue is not reproducible on Firefox 65.0a1(2018-11-09)

This was a very helpful additional note. It makes me think that the feature is still working as intended, but the logging is different.
Could you flip the services.sync.log.appender.file.logOnSuccess preference to true and try again?
Flags: needinfo?(mihai.boldan)
It seems that the logs are displayed after enabling the services.sync.log.appender.file.logOnSuccess pref.
Can you please confirm that the logs should be displayed only when sending a tab from desktop to iOS?
If I send a tab from iOS device to Desktop, there are no new logs in about:sync-log.
Flags: needinfo?(mihai.boldan) → needinfo?(eoger)
It should also appear, either in the browser toolbox console or about:sync-log. Can you set identity.fxaccounts.loglevel to Info and try again?
Flags: needinfo?(eoger) → needinfo?(mihai.boldan)
So, I managed to create identity.fxaccounts.loglevel - Info pref and sent a tab between devices without setting services.sync.log.appender.file.logOnSuccess preference to true and no logs were displayed in about:sync-log.
With identity.fxaccounts.loglevel set to "Info" and services.sync.log.appender.file.logOnSuccess set to "True" the logs are correctly displayed. 
I also confirm that logs for both actions are displayed, sending and receiving tabs. It only takes a little more for the logs when sending a tab from iOS device to mobile, to be displayed in the about:sync-log page. 
Please let me know if I can help any further with the investigation .
Flags: needinfo?(mihai.boldan) → needinfo?(eoger)
Sounds like the expected behavior, thanks for confirming!
Should we close this?
Flags: needinfo?(eoger)
From previous comments it sounds like this difference between 64 and 65 is expected as a result of

#if defined(NIGHTLY_BUILD)
pref("services.sync.log.appender.file.logOnSuccess", true);
#else
pref("services.sync.log.appender.file.logOnSuccess", false);
#endif

Closing.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.