Closed Bug 1506128 Opened 6 years ago Closed 5 years ago

The share button is not visible inside the address bar

Categories

(Firefox :: Menus, defect, P1)

All
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 + fixed
firefox65 --- verified

People

(Reporter: emilghitta, Assigned: daleharvey)

References

Details

Attachments

(3 files)

Attached image share.gif
[Affected versions]:
Firefox 65.0a1 (BuildId:20181108100100)
Firefox 64.0b7 (BuildId:20181105164654)

[Unaffected versions]:
Firefox 63.0.1 (BuildId:20181030165643)
Firefox 60.3.0esr (BuildId:20181017185317)

[Affected platforms]:
Windows 10 64bit

[Steps to reproduce]:
1. Launch Firefox.
2. Click the Page Actions button.
3. Right click on the "share" button.
4. Click the "Add to address bar" option.

[Expected result]:
The share button icon is displayed inside the address bar.

[Actual result]:
The share button icon is not visible.

[Regression range]:
This behavior was introduced with Bug 1363169

[Notes]:
For further information regarding this issue, please observe the attached screencast.
Flags: needinfo?(dharvey)
Priority: -- → P1
Assignee: nobody → dharvey
Flags: needinfo?(dharvey)
Attached file Phabricator
Attachment #9024173 - Flags: review?(gijskruitbosch+bugs)
Attachment #9024173 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/93f251e48d4d
Add share icon rule for url bar. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/93f251e48d4d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Dale, wanna request beta uplift for this? :-)
Flags: needinfo?(dharvey)
This issue is verified fixed using Firefox 65.0a1 (BuildId:20181112220107) on Windows 10 64bit.
Status: RESOLVED → VERIFIED
Attached image fill-opacity.PNG
chrome://browser/skin/share.svg needs fill-opacity="context-fill-opacity". Please see attachment.
Thanks for pointing that out Bruce, have filed and will fix @ https://bugzilla.mozilla.org/show_bug.cgi?id=1507444 and request uplift for both at the same time
Flags: needinfo?(dharvey)
Comment on attachment 9024173 [details]
Phabricator

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1363169

User impact if declined: Confusing missing icon

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Minor CSS addition

String changes made/needed:
Attachment #9024173 - Flags: approval-mozilla-beta?
(In reply to Dale Harvey (:daleharvey) from comment #8)
> List of other uplifts needed: None

(In reply to Dale Harvey (:daleharvey) from comment #7)
> Thanks for pointing that out Bruce, have filed and will fix @
> https://bugzilla.mozilla.org/show_bug.cgi?id=1507444 and request uplift for
> both at the same time

This has me confused.
Flags: needinfo?(dharvey)
Sorry, the patches dont actually depend on one another and I figured I was better waiting for verification on nightly before asking for uplift so figured I didnt need to wait on one for the other, will just request uplift once its been verified
Flags: needinfo?(dharvey)
Comment on attachment 9024173 [details]
Phabricator

Thanks for the explanation :)

Approved for 64.0b11
Attachment #9024173 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: