Closed
Bug 1506128
Opened 6 years ago
Closed 5 years ago
The share button is not visible inside the address bar
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | + | fixed |
firefox65 | --- | verified |
People
(Reporter: emilghitta, Assigned: daleharvey)
References
Details
Attachments
(3 files)
[Affected versions]: Firefox 65.0a1 (BuildId:20181108100100) Firefox 64.0b7 (BuildId:20181105164654) [Unaffected versions]: Firefox 63.0.1 (BuildId:20181030165643) Firefox 60.3.0esr (BuildId:20181017185317) [Affected platforms]: Windows 10 64bit [Steps to reproduce]: 1. Launch Firefox. 2. Click the Page Actions button. 3. Right click on the "share" button. 4. Click the "Add to address bar" option. [Expected result]: The share button icon is displayed inside the address bar. [Actual result]: The share button icon is not visible. [Regression range]: This behavior was introduced with Bug 1363169 [Notes]: For further information regarding this issue, please observe the attached screencast.
Updated•6 years ago
|
Flags: needinfo?(dharvey)
Updated•6 years ago
|
tracking-firefox64:
--- → ?
Priority: -- → P1
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dharvey
Flags: needinfo?(dharvey)
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9024173 -
Flags: review?(gijskruitbosch+bugs)
Updated•5 years ago
|
Attachment #9024173 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/93f251e48d4d Add share icon rule for url bar. r=Gijs
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/93f251e48d4d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Reporter | ||
Comment 5•5 years ago
|
||
This issue is verified fixed using Firefox 65.0a1 (BuildId:20181112220107) on Windows 10 64bit.
Status: RESOLVED → VERIFIED
chrome://browser/skin/share.svg needs fill-opacity="context-fill-opacity". Please see attachment.
Assignee | ||
Comment 7•5 years ago
|
||
Thanks for pointing that out Bruce, have filed and will fix @ https://bugzilla.mozilla.org/show_bug.cgi?id=1507444 and request uplift for both at the same time
Flags: needinfo?(dharvey)
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9024173 [details] Phabricator [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1363169 User impact if declined: Confusing missing icon Is this code covered by automated tests?: No Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Minor CSS addition String changes made/needed:
Attachment #9024173 -
Flags: approval-mozilla-beta?
Comment 9•5 years ago
|
||
(In reply to Dale Harvey (:daleharvey) from comment #8) > List of other uplifts needed: None (In reply to Dale Harvey (:daleharvey) from comment #7) > Thanks for pointing that out Bruce, have filed and will fix @ > https://bugzilla.mozilla.org/show_bug.cgi?id=1507444 and request uplift for > both at the same time This has me confused.
Flags: needinfo?(dharvey)
Assignee | ||
Comment 10•5 years ago
|
||
Sorry, the patches dont actually depend on one another and I figured I was better waiting for verification on nightly before asking for uplift so figured I didnt need to wait on one for the other, will just request uplift once its been verified
Flags: needinfo?(dharvey)
Comment 11•5 years ago
|
||
Comment on attachment 9024173 [details]
Phabricator
Thanks for the explanation :)
Approved for 64.0b11
Attachment #9024173 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 12•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/8d14223f8f75
You need to log in
before you can comment on or make changes to this bug.
Description
•